chore(): sync with feature-8.0 #28642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that Dependabot PRs never had anyone assigned: #28586 The reason was that we removed `* @ionic-team/framework` when we adjusted the codeowners in #27573. My original reasoning for why we should remove it was wrong. GitHub only assigns reviewers within a team if the team itself is assigned. By removing the team from being reviewed, only people listed in the codeowners file would be assigned. As an added example, PRs that do not match codeowners currently have no one assigned: #28430
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When using `.setContent`, the initial page template is lacking key metadata that will result in AXE violations. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds a default `lang` to the `html` document root - Adds a default `title` tag ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Release 7.5.7
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.7.2 to 4.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🌞 v4.8.0 (2023-11-27)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>hydrate:</strong> prevent dead code elimination of patch dom implementation (<a href="https://redirect.github.com/ionic-team/stencil/issues/4966">#4966</a>) (<a href="https://github.com/ionic-team/stencil/commit/5e3605779589105d6a3da73fcfc2bbe5ceeb5def">5e36057</a>)</li> <li><strong>mock-doc:</strong> add <code>getAttributeNode</code> to mock elements (<a href="https://redirect.github.com/ionic-team/stencil/issues/5070">#5070</a>) (<a href="https://github.com/ionic-team/stencil/commit/4e840e0e0e6af86e1cda551f3ec9e50ac57417fa">4e840e0</a>)</li> <li><strong>mock-doc:</strong> add inert to HTMLAttributes (<a href="https://redirect.github.com/ionic-team/stencil/issues/5072">#5072</a>) (<a href="https://github.com/ionic-team/stencil/commit/71a4110bbce310d2f405557acb25de552db4f78f">71a4110</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5071">#5071</a></li> <li><strong>runtime:</strong> apply textnodes to shadow DOM instead of light DOM (<a href="https://redirect.github.com/ionic-team/stencil/issues/4946">#4946</a>) (<a href="https://github.com/ionic-team/stencil/commit/217d58894959d4b05d6dda590f006c35772c321c">217d588</a>)</li> <li><strong>test:</strong> pass jest args correctly for v28/29 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5068">#5068</a>) (<a href="https://github.com/ionic-team/stencil/commit/5c4ac328052c1a1f1c13d6393c3d9875ba3573c1">5c4ac32</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>declarations:</strong> add popover attributes to JSX declarations (<a href="https://redirect.github.com/ionic-team/stencil/issues/5064">#5064</a>) (<a href="https://github.com/ionic-team/stencil/commit/f73aa149f06dd3014bfbc2ab7223f8363b859b41">f73aa14</a>)</li> <li><strong>runtime:</strong> proxy form associated custom element lifecycle callbacks (<a href="https://redirect.github.com/ionic-team/stencil/issues/4939">#4939</a>) (<a href="https://github.com/ionic-team/stencil/commit/ca53dbb02ec4babd2957c12eb1a787eee98d2645">ca53dbb</a>)</li> </ul> <h2>Thanks</h2> <p>🎉 Thanks <a href="https://github.com/HansClaasen"><code>@HansClaasen</code></a> for their contributions! 🎉</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🌞 <a href="https://github.com/ionic-team/stencil/compare/v4.7.2...v4.8.0">4.8.0</a> (2023-11-27)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>hydrate:</strong> prevent dead code elimination of patch dom implementation (<a href="https://redirect.github.com/ionic-team/stencil/issues/4966">#4966</a>) (<a href="https://github.com/ionic-team/stencil/commit/5e3605779589105d6a3da73fcfc2bbe5ceeb5def">5e36057</a>)</li> <li><strong>mock-doc:</strong> add <code>getAttributeNode</code> to mock elements (<a href="https://redirect.github.com/ionic-team/stencil/issues/5070">#5070</a>) (<a href="https://github.com/ionic-team/stencil/commit/4e840e0e0e6af86e1cda551f3ec9e50ac57417fa">4e840e0</a>)</li> <li><strong>mock-doc:</strong> add inert to HTMLAttributes (<a href="https://redirect.github.com/ionic-team/stencil/issues/5072">#5072</a>) (<a href="https://github.com/ionic-team/stencil/commit/71a4110bbce310d2f405557acb25de552db4f78f">71a4110</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5071">#5071</a></li> <li><strong>runtime:</strong> apply textnodes to shadow DOM instead of light DOM (<a href="https://redirect.github.com/ionic-team/stencil/issues/4946">#4946</a>) (<a href="https://github.com/ionic-team/stencil/commit/217d58894959d4b05d6dda590f006c35772c321c">217d588</a>)</li> <li><strong>test:</strong> pass jest args correctly for v28/29 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5068">#5068</a>) (<a href="https://github.com/ionic-team/stencil/commit/5c4ac328052c1a1f1c13d6393c3d9875ba3573c1">5c4ac32</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>declarations:</strong> add popover attributes to JSX declarations (<a href="https://redirect.github.com/ionic-team/stencil/issues/5064">#5064</a>) (<a href="https://github.com/ionic-team/stencil/commit/f73aa149f06dd3014bfbc2ab7223f8363b859b41">f73aa14</a>)</li> <li><strong>runtime:</strong> proxy form associated custom element lifecycle callbacks (<a href="https://redirect.github.com/ionic-team/stencil/issues/4939">#4939</a>) (<a href="https://github.com/ionic-team/stencil/commit/ca53dbb02ec4babd2957c12eb1a787eee98d2645">ca53dbb</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/cddcad8ca203d0d7d5c5c8fcda188759d65bff3d"><code>cddcad8</code></a> v4.8.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5103">#5103</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/bcb17ac6cbebf6f27292f7e94bea20e482494a0e"><code>bcb17ac</code></a> docs(runtime): add interface docs to <code>HostRef</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/4871">#4871</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/edc9f384ac30970fd3c1221fc0dc2457a60a73ac"><code>edc9f38</code></a> chore(deps): update dependency npm to v10.2.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5085">#5085</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/49c760768735d412548766cc0528c6a25b55871d"><code>49c7607</code></a> chore(deps): update typescript-eslint to v6.11.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5087">#5087</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9c8790d601f5bda91283d9f5961f1411370f9e84"><code>9c8790d</code></a> test(vdom): adding tests for insertVdomAnnotations (<a href="https://redirect.github.com/ionic-team/stencil/issues/4867">#4867</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/13ec78e1bb28cd8db1ceab2fa584831e9ef73891"><code>13ec78e</code></a> chore(deps): update dependency puppeteer to v21.5.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5086">#5086</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9a3e81cb773aedc65557768280d961c12780cf9f"><code>9a3e81c</code></a> chore(deps): update dependency <code>@types/node</code> to v20.9.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5084">#5084</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/217d58894959d4b05d6dda590f006c35772c321c"><code>217d588</code></a> fix(runtime): apply textnodes to shadow DOM instead of light DOM (<a href="https://redirect.github.com/ionic-team/stencil/issues/4946">#4946</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/ca53dbb02ec4babd2957c12eb1a787eee98d2645"><code>ca53dbb</code></a> feat(runtime): proxy form associated custom element lifecycle callbacks (<a href="https://redirect.github.com/ionic-team/stencil/issues/4939">#4939</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/7c86019e5910935e8731e10bd7156d25a85e997c"><code>7c86019</code></a> refactor(build): stop removing process.binding in compiler (<a href="https://redirect.github.com/ionic-team/stencil/issues/5078">#5078</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.7.2...v4.8.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Testing dark mode is manual per test in Playwright. Ionic developer needs to setup the variables and assign them to a selector that applies in the class. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The `.setContent` API will now work with a new config option to test dark mode automatically without additional configuration/test set-up. - Default theme is no theme (fallback theme) - Screenshot names and test titles remain the same for all existing tests. Only tests that opt into a theme will be pre-pended with `-dark` or `-light` (as an example for current themes). ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: resolves #28524 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Watchers in Stencil are constructed sometime between `connectedCallback` and `componentDidLoad`. If a property is set/changed during that time it is possible for the callback associated with the watcher to not fire because the watcher has not been setup yet. This is most often with `dist-custom-elements` and frameworks such as Angular when using a binding (i.e. `[trigger]` instead of `trigger`) ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The trigger callback associated with the watcher is manually called in `componentDidLoad` for each overlay. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.5.5-dev.11699974376.13a15397` Note: This is a timing related bug due to a behavior in Stencil, so I did not write automated tests. However, I manually verified that this issue a) reproduces on `main` and b) is fixed with this dev build for each overlay component.
chore: sync with main
Issue number: resolves #28611 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> It's not possible to pass props that are not camelCase to the `IonNav` component. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - It is now possible to set a props with kebab-case instead of camelCase (for example, `root-params` instead of `rootParams`) ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->⚠️ This is my first PR for ionic so I hope I didn't miss important steps into the process. I also checked on my project that the fix is working well. Thank you! 🙂 --------- Co-authored-by: Sean Perkins <sean@ionic.io>
…#28616) Issue number: Resolves #26524 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## Definitions **Parameterized routes**: A route that includes one or more variables in the path segments, such as `/form/:index`. ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When an application routes from a parameterized route, to an intermediary route, to the same parameterized route, but with a different value/url, Ionic's routing logic is incorrectly reusing the view item from the first instance of the parameterized route instead of calculating that the matched path is different. This results in the wrong view item being recycled and rendered. Another way of representing it: - User navigates to `/form/0` which resolves `FormPage` - User enters `0` into the form and submits the form - User navigates to `/link`, which resolves `LinkPage` - User navigates to `/form/1`, which resolves `FormPage` - However, instead of creating a new instance of `FormPage` it is reusing the instance of `FormPage` from `/form/0` which includes the form having `0` in the input. - The user now sees a "new view", but with cached data in the form. This is not expected or desired. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Ionic's routing logic will validate if the entering view item matches the match route data before reusing it. This results in new instances of the view item being constructed when using parameterized routes. https://github.com/ionic-team/ionic-framework/assets/13732623/e7e3d03f-2848-4429-9f60-9074d0761e45 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev-build: `7.5.8-dev.11701383555.17254408`
…8614) Issue number: Related to #18132 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The documentation about the `autofocus` prop is unclear and does not accurately reflect how it actually works across browsers and devices. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The documentation for `autofocus` and `setFocus` are more detailed. - The documentation links to the relevant page in the docs. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The labeler action is currently failing: https://github.com/ionic-team/ionic-framework/actions/runs/7090913880/job/19298918578?pr=28622. This is happening due to a breaking change in v5 of the action. We currently pull from `main` for this action so we are now receiving v5 of the action: https://github.com/ionic-team/ionic-framework/blob/fe3c3d500a2afd716ebde81a75b357b7c79d4920/.github/workflows/label.yml#L16 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - This PR updates the action explicitly to v5 so we don't unexpectedly take on breaking changes - This PR also updates the labeler yaml file to account for the v5 breaking changes ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.8.0 to 4.8.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🍹 v4.8.1 (2023-12-04)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>runtime:</strong> apply nonce to data styles before DOM insert (<a href="https://redirect.github.com/ionic-team/stencil/issues/5112">#5112</a>) (<a href="https://github.com/ionic-team/stencil/commit/df46fdc0cb9168171546e335a5628b25909fdd89">df46fdc</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5102">#5102</a></li> <li><strong>runtime:</strong> call form-associated lifecycle callbacks w/ <code>this</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/5104">#5104</a>) (<a href="https://github.com/ionic-team/stencil/commit/1ac8aa3da139656c82914fda7eb9e8de62cba56d">1ac8aa3</a>)</li> <li><strong>testing:</strong> re-add Puppeteer <code>asElement()</code> calls (<a href="https://redirect.github.com/ionic-team/stencil/issues/5114">#5114</a>) (<a href="https://github.com/ionic-team/stencil/commit/0c843f8d19e6ee04c02ae8699c76c33d5ebb1c70">0c843f8</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5113">#5113</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🍹 <a href="https://github.com/ionic-team/stencil/compare/v4.8.0...v4.8.1">4.8.1</a> (2023-12-04)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>runtime:</strong> apply nonce to data styles before DOM insert (<a href="https://redirect.github.com/ionic-team/stencil/issues/5112">#5112</a>) (<a href="https://github.com/ionic-team/stencil/commit/df46fdc0cb9168171546e335a5628b25909fdd89">df46fdc</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5102">#5102</a></li> <li><strong>runtime:</strong> call form-associated lifecycle callbacks w/ <code>this</code> (<a href="https://redirect.github.com/ionic-team/stencil/issues/5104">#5104</a>) (<a href="https://github.com/ionic-team/stencil/commit/1ac8aa3da139656c82914fda7eb9e8de62cba56d">1ac8aa3</a>)</li> <li><strong>testing:</strong> re-add Puppeteer <code>asElement()</code> calls (<a href="https://redirect.github.com/ionic-team/stencil/issues/5114">#5114</a>) (<a href="https://github.com/ionic-team/stencil/commit/0c843f8d19e6ee04c02ae8699c76c33d5ebb1c70">0c843f8</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5113">#5113</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/28f794ea0d3a1d67586210c45b2709812d1e6e96"><code>28f794e</code></a> Release v4.8.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5130">#5130</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/2fd398a6cf33d8e16bcc0b2f4064813fb8176089"><code>2fd398a</code></a> chore(deps): update dependency <code>@rollup/pluginutils</code> to v5.1.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5126">#5126</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/84feb5aee2ced354c19af1a3e38e56fa3356a973"><code>84feb5a</code></a> chore(deps): update typescript-eslint to v6.13.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5128">#5128</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/cf4a70150c91e9dcc6690396a7e1b3a0a1e92215"><code>cf4a701</code></a> fix(compiler): revert changes to style import transformer (<a href="https://redirect.github.com/ionic-team/stencil/issues/5125">#5125</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/df32ceb4ae33442e8eb4492adb6a06c7cf52bb8c"><code>df32ceb</code></a> chore(deps): update dependency fs-extra to v11.2.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5127">#5127</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/4cdb725fb7533a3aa1cecc6ac4cd518b90821834"><code>4cdb725</code></a> chore(deps): update dependency dts-bundle-generator to v9 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5129">#5129</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/3ef8fa070aa31dc6054fdb164f28fa7e90f79af5"><code>3ef8fa0</code></a> chore(deps): update dependency <code>@types/eslint</code> to v8.44.8 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5122">#5122</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1342eec5778d54f305e2bc773a3004d53957f2fd"><code>1342eec</code></a> chore(deps): update dependency <code>@types/node</code> to v20.10.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5123">#5123</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/7591dce85e3b19ab623752341344d009881032be"><code>7591dce</code></a> fix(compiler): ensure not to import duplicate style identifier (<a href="https://redirect.github.com/ionic-team/stencil/issues/5119">#5119</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/7302e3f81a68df054676f341166f8aeba806c589"><code>7302e3f</code></a> chore(deps): update node.js to v20.10.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5117">#5117</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.8.0...v4.8.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: sync feature-8.0 with main
amandaejohnston
requested review from
brandyscarney,
thetaPC,
liamdebeasi and
sean-perkins
as code owners
liamdebeasi
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information