chore(ci): update labeler workflow for labeler@v5 #28627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
Looks like I may have implemented this correctly, but the labeler is pulling the wrong version of the YAML file: https://github.com/ionic-team/ionic-framework/actions/runs/7092087270/job/19302623106?pr=28627 |
liamdebeasi
requested review from
brandyscarney
and removed request for
a team
|
Spoke with Sean and our current thinking is we need to merge this to see any changes in the state of the GitHub Actions job. Worst case is this continues to fail, but no one should be blocked on merging since it's not a required status check. |
sean-perkins
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The labeler action is currently failing: https://github.com/ionic-team/ionic-framework/actions/runs/7090913880/job/19298918578?pr=28622. This is happening due to a breaking change in v5 of the action.
We currently pull from
mainfor this action so we are now receiving v5 of the action:ionic-framework/.github/workflows/label.yml
Line 16 in fe3c3d5
What is the new behavior?
Does this introduce a breaking change?
Other information