-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(picker): add inline picker #28689
Commits on Nov 28, 2023
-
refactor(picker): deprecate ion-picker and ion-picker-column (#28584)
BREAKING CHANGE: `ion-picker` and `ion-picker-column` have been renamed to `ion-picker-legacy` and `ion-picker-legacy-column`, respectively. This change was made to accommodate the new inline picker component while allowing developers to continue to use the legacy picker during this migration period.
Configuration menu - View commit details
-
Copy full SHA for cc45e22 - Browse repository at this point
Copy the full SHA cc45e22View commit details -
refactor(picker): rename internal picker components to ion-picker and…
… ion-picker-column (#28589)
Configuration menu - View commit details
-
Copy full SHA for 5e47412 - Browse repository at this point
Copy the full SHA 5e47412View commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0b46964 - Browse repository at this point
Copy the full SHA 0b46964View commit details
Commits on Dec 5, 2023
-
chore(): sync with feature-8.0 (#28642)
Issue number: # --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - - - ## Does this introduce a breaking change? - [ ] Yes - [ ] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com> Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com> Co-authored-by: ionitron <hi@ionicframework.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Perkins <sean@ionic.io> Co-authored-by: Éric Le Maître <eric.erwan.le.maitre@gmail.com> Co-authored-by: Shawn Taylor <shawn@ionic.io>
Configuration menu - View commit details
-
Copy full SHA for fe3070b - Browse repository at this point
Copy the full SHA fe3070bView commit details -
feat(picker-column): add prefix and suffix slots (#28603)
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The new picker component does not have a counterpart for the `prefix` and `suffix` properties on the old picker column. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - `prefix` and `suffix` slots added. - Picker items wrapped in a new `.picker-opts` element for positioning purposes, similar to the legacy picker column. This necessitated additional changes to functionality and styling, since previously the items were direct descendants of the host. - New `setFocus` method added. This gets around a browser bug in Firefox where calling `focus()` on the column doesn't correctly move focus, as the nearest focusable element (`.picker-opts`) is in the shadow DOM. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> While you can no longer call `focus()` on the column in Firefox and must use `setFocus()` instead, this isn't considered a breaking change because this component isn't public API yet. ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Configuration menu - View commit details
-
Copy full SHA for cf9fe31 - Browse repository at this point
Copy the full SHA cf9fe31View commit details
Commits on Dec 8, 2023
-
feat(picker): integrate picker-column-option with picker (#28666)
Issue number: N/a --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The team would like to add a way of using the picker inline with page content. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - This PR integrates the column option component with the rest of the picker so that is functional. This PR is a combination of commits from previously reviewed PRs. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Configuration menu - View commit details
-
Copy full SHA for 9575c88 - Browse repository at this point
Copy the full SHA 9575c88View commit details
Commits on Dec 11, 2023
-
feat(picker): add css variables for picker highlight and fade (#28654)
Issue number: N/A --------- ## What is the current behavior? Picker has the following CSS variables for styling: `--wheel-fade-background-rgb` and `--wheel-highlight-background` These variables make sense when used from `ion-datetime`, but picker does not need the `wheel` prefix. ## What is the new behavior? ### Datetime - Adds `--wheel-highlight-border-radius` - Keeps `--wheel-fade-background-rgb` and `--wheel-highlight-background` - Assigns these variables to picker's new variables ```scss ion-picker { --highlight-background: var(--wheel-highlight-background); --highlight-border-radius: var(--wheel-highlight-border-radius); --fade-background-rgb: var(--wheel-fade-background-rgb); } ``` ### Picker Renames `--wheel-fade-background-rgb` and `--wheel-highlight-background` and adds another CSS variables to `ion-picker`: - Renames `--wheel-fade-background-rgb` to `--fade-background-rgb` - Renames `--wheel-highlight-background` to `--highlight-background` - Adds `--highlight-border-radius` ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information PR to update the [Datetime docs](ionic-team/ionic-docs#3303) --------- Co-authored-by: ionitron <hi@ionicframework.com>
Configuration menu - View commit details
-
Copy full SHA for 5685a16 - Browse repository at this point
Copy the full SHA 5685a16View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab62ea9 - Browse repository at this point
Copy the full SHA ab62ea9View commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e4797a4 - Browse repository at this point
Copy the full SHA e4797a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08ea19c - Browse repository at this point
Copy the full SHA 08ea19cView commit details