fix(select): add icon-inner & placeholder part #20605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
This can be considered a feature or a fix, due to the fact it adds a new part, but we haven't documented any of these yet so I'm not sure which way to lean here.
You cannot change the opacity of the select icon or target the placeholder color with the current parts.
Placeholder - Due to the fact that the placeholder and value share the same div, you would have to be able to target it based on the
select-placeholder
class which does not work with parts.Select Icon - The opacity was set on the inner icon, so you can change the color using
::part(icon)
but it will still have the default.33
opacity. I added a part foricon-inner
since that is where the actual arrow is created, and also moved opacity so it is set on the parent wrapper which fixes this problem.Issue Number: #17248
What is the new behavior?
icon-inner
andplaceholder
partsDoes this introduce a breaking change?
Other information