Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): gitignore dist output #1777

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix(react): gitignore dist output #1777

merged 1 commit into from
Apr 28, 2023

Conversation

sean-perkins
Copy link
Contributor

When moving to Vite for the React starters, the output directory for the compiled output changed from /build to /dist. This PR updates the .gitignore to include the new output directory. The old directory remains in the .gitignore as I am unsure if all templates the base template is used with, is on Vite.

Resolves: #1776

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-perkins sean-perkins merged commit 98bc4d7 into main Apr 28, 2023
@sean-perkins sean-perkins deleted the fix/react-prod-folder branch April 28, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(react): .gitignore correct production folder
3 participants