chore(angular-standalone): add preloading strategy #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sean-perkins, I see that the tests passed correctly, let me know if I can help with anything else for the merge. |
|
@sean-perkins , I see that the tests continue to fail, the strange thing is that I don't modify any of that, how could I help? Creating the pull again from scratch? |
|
@luisbytes to be honest I'm not certain why they are failing consistently here. I didn't run into with a PR after yours was created: #1843 and was able to re-run the action for a PR from Liam. I was able to reproduce the behavior locally, but only intermittently, so the test itself is likely flaky. It's only a challenge in the unit test, so I'm inclined to just skip it for now and come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that the starter template with Angular and ngModules has preloading enabled by default, but the standalone one does not