chore(angular): upgrade to official 18 release #1846
Conversation
thetaPC
requested review from
joselrio and
brandyscarney
and removed request for
a team
| @@ -52,6 +52,6 @@ | |||
| "karma-coverage": "~2.2.0", | |||
| "karma-jasmine": "~5.1.0", | |||
| "karma-jasmine-html-reporter": "~2.1.0", | |||
| "typescript": "~5.2.2" | |||
| "typescript": "~5.4.0" | |||
There was a problem hiding this comment.
Our test app is using ^5.4.0 vs. ~5.4.0. Do you have a recommendation on why one is more appropriate for the test app vs. the starters?
This applies to both package.json diffs.
There was a problem hiding this comment.
No recommendation. I was simply following the structure of the starters. I also don't have any strong feelings. What is your suggestion here? ^5.4.0 or ~5.4.0?
There was a problem hiding this comment.
The answer to this depends on whether or not we want people to always get the latest patch release or the latest minor release for typescript. It looks like typescript doesn't follow SemVer and pushes breaking changes in minor versions so we are probably safer sticking to patches.
There was a problem hiding this comment.
Going to merge but we can always adjust this in another PR.
Issue number: internal
What is the current behavior?
Angular and angular standalone starters are using v17.
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A