Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(json): add mode to docs-json docs #1417

Merged
merged 3 commits into from
May 3, 2024
Merged

docs(json): add mode to docs-json docs #1417

merged 3 commits into from
May 3, 2024

Conversation

rwaskiewicz
Copy link
Member

add an example of the output for modes associated with a stylesheet.

associated with ionic-team/stencil#5718

STENCIL-1269

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 5:05pm

@rwaskiewicz rwaskiewicz marked this pull request as ready for review April 30, 2024 15:55
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner April 30, 2024 15:55
@rwaskiewicz rwaskiewicz requested review from christian-bromann and alicewriteswrongs and removed request for a team April 30, 2024 15:55
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth removing this one too

docs/documentation-generation/docs-json.md Outdated Show resolved Hide resolved
docs/documentation-generation/docs-json.md Outdated Show resolved Hide resolved
If the style sheet is configured to be used with [a specific mode](../components/styling.md), the mode associated with
the CSS property will be provided as well:

```diff title="Example docs-json Output with Mode"
"styles": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to update this as well when I backport things

docs/documentation-generation/docs-json.md Outdated Show resolved Hide resolved
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rwaskiewicz
Copy link
Member Author

rwaskiewicz commented May 3, 2024

Thanks all! Since this is new functionality, no backport of the docs needed (leaving a note for future us).

rwaskiewicz and others added 3 commits May 3, 2024 13:02
add an example of the output for modes associated with a stylesheet.

associated with ionic-team/stencil#5718

STENCIL-1269
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
@rwaskiewicz rwaskiewicz merged commit 46c5d0a into main May 3, 2024
5 checks passed
@rwaskiewicz rwaskiewicz deleted the rw/style-mode branch May 3, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants