fix(rules): uncombine ion-navbar-is-now-ion-toolbar rule #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the rule was adding an ion-back-button (and container) as well as changing the tag names to ion-toolbar. We have a rule for warning about the missing back button: `ion-back-button-not-added-by-default` It's probably best to keep these separated for simplicity
|
I agree. I like being able to split up the breaking and non-breaking rules. We can have two rulesets; a safe one and an all fixes (YOLO) set. |
cwoolum
pushed a commit
that referenced
this pull request
Jul 24, 2018
# [1.4.0](v1.3.0...v1.4.0) (2018-07-24) ### Bug Fixes * **rules:** uncombine ion-navbar-is-now-ion-toolbar rule ([#38](#38)) ([c13764f](c13764f)) ### Features * **rules:** add ion-back-button-not-added-by-default rule ([#26](#26)) ([65a168f](65a168f)) * **rules:** add ion-buttons-attributes-renamed rule ([2a480dd](2a480dd)) * **rules:** add ion-col-attributes-renamed rule ([#33](#33)) ([2cb436f](2cb436f)) * **rules:** add ion-fab-fixed-content rule ([#29](#29)) ([7fbff99](7fbff99)) * **rules:** add ion-icon-attribute-is-active-removed rule ([#30](#30)) ([0679c7b](0679c7b)) * **rules:** add ion-item-attributes-renamed rule ([#34](#34)) ([d08e0ba](d08e0ba)) * **rules:** add ion-item-divider-ion-label-required rule ([#36](#36)) ([b0a6cb1](b0a6cb1)) * **rules:** add ion-item-ion-label-required rule ([#32](#32)) ([098bd7f](098bd7f)) * **rules:** add ion-item-option-is-now-an-element rule ([04dae1c](04dae1c)) * **rules:** add ion-item-options-attribute-values-renamed rule ([d3306e8](d3306e8)) * **rules:** add ion-label-attributes-renamed rule ([#28](#28)) ([0601a0c](0601a0c)) * **rules:** add ion-list-header-ion-label-required rule ([#35](#35)) ([94503c2](94503c2)) * **rules:** add ion-menu-toggle-is-now-an-element rule ([591b10a](591b10a)) * **rules:** add ion-option-is-now-ion-select-option rule ([6274f6a](6274f6a)) * **rules:** add ion-radio-group-is-now-an-element rule ([eb933cc](eb933cc)) * **rules:** add ion-range-attributes-renamed rule ([#37](#37)) ([6cac6a2](6cac6a2)) * **rules:** add ion-spinner-attribute-values-renamed rule ([#31](#31)) ([c4db1f8](c4db1f8)) * **rules:** add ion-text-is-now-an-element rule ([fe94a1f](fe94a1f)) * **rules:** allow rule to work with ion-loading, ion-infinite-scroll, and ion-refresher ([9e8f626](9e8f626))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cwoolum What are your thoughts? I think having the behavior of automatically adding the back button may not be desirable in all cases and it kinda clashes with our existing rule