Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netadr_t adr cache in SV_MasterHeartbeat #161

Closed
wants to merge 1 commit into from

Conversation

vloup
Copy link

@vloup vloup commented Nov 14, 2015

As TimeDoctor said, they are currently transitioning to a new master server. The problem is that people keep registering to the wrong ip until they have restarted their server.

This patch removes the ip cache and forces the hostname resolution to be done everytime a heartbeat is prepared to be sent.

I am open to any questions, remarks or improvements.

@vloup
Copy link
Author

vloup commented Nov 16, 2015

@ensiform : Interesting solution, what do you think is the best? Forcing to reload the adr cache every so often like what Raven did or just plain delete it like I did?

@ensiform
Copy link

I think the timer is best. Having none at all seems counter productive and will probably be expensive on older server providers. So that's my 2¢.

@vloup
Copy link
Author

vloup commented Nov 16, 2015

So I gave a try to "backport" Raven's code with few minor edits in vloup@ba5f898. Should I now rebase and replace the code in the pull request by this one?

@zturtleman
Copy link
Member

Update master addresses every 24 hours in 973e0a7.

@zturtleman zturtleman closed this Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants