enhancement on python run_command #218

hackjutsu · 2016-03-24T17:32:51Z

In the justlaunch scenario, the python script should move forward only if it launches the app successfully. If it fails, it should propagate the exit code out to notify the the users to handle the failure (perhaps relaunch?), instead of being trapped in the following loop in the safequit method.
The changes aim to solve the hanging issue #189 of ios-deploy --justlaunch --debug --bundle my.app.
I only tested the changes in the -justlaunch scenario.

1. the python script should move forward only if it launches the app successfully

omefire · 2016-04-04T21:43:35Z

I've tested this change with 'cordova', and running 'cordova run ios' still results in the process hanging on this line:

(lldb)     command script add -s asynchronous -f fruitstrap_3730c9a14ec0f5fb666eaa1f758ddd685dee2d55.safequit_command safequit
(lldb)     connect
(lldb)     run
success
(lldb)     safequit

akofman · 2016-04-04T22:08:59Z

Same here using XCode 7.3 and ios-deploy with your fix.

hackjutsu · 2016-04-04T22:21:04Z

@omefire @akofman Thanks for the feedback:)

How often does it happen? I tested with Xcode 7.2 with 500 continuous launches. Maybe that is not enough...
Would it be a good idea to add a timeout for the safequit method? If the ios-deploy fails to launch the app, it should at least return an error code after a timeout rather than just hanging.

Update:
I'm surprised that the hang now happens for every launch with Xcode 7.3, it only happened once or twice for every 100 launches before. I might need some actual testing with the new Xcode before I can reach any conclustion.

akofman · 2016-04-04T22:22:19Z

I just tested it manually and it happens every times :/

omefire · 2016-04-04T22:30:33Z

Same here, manual test and I always face this issue.

shazron · 2016-04-05T00:47:57Z

Might be an Xcode 7.3 thing.

akofman · 2016-04-05T07:27:31Z

@shazron : if it can help, XCode 7.2 is using lldb-340.4.119.1 while XCode 7.3 is using lldb-350.0.21.3.

akofman · 2016-04-05T19:36:50Z

I tried a fix but not sure it is fine for every version of XCode : akofman@396daae.
Could you have a try guys ?

shazron · 2016-04-05T19:46:13Z

I'll check it out @akofman

shazron · 2016-04-05T19:57:00Z

@akofman good news, and bad news -- it solves the hanging issue, but now the app quits after launch.

akofman · 2016-04-05T19:57:51Z

Ah ? I'll try on ios9.3 and XCode 7.3 and the app stayed alive.

shazron · 2016-04-05T19:59:11Z

I'm using Xcode 7.3, iOS 9.3.1 (iPhone 6s), and launching using "cordova run --device"

akofman · 2016-04-05T20:00:00Z

Ah yes sorry, I was testing on ios8. With ios9.3, indeed the app quits. grrrr

akofman · 2016-04-05T20:38:42Z

I noticed the app doesn't quit actually but goes in background.

shazron · 2016-04-05T21:24:07Z

So when I commented out this line:
https://github.com/phonegap/ios-deploy/blob/77654faabd890103fad5beea9cc7a80260f00f21/src/scripts/lldb.py#L56

After a wait, I now get:

(lldb)     safequit
Process 4113 detached
Error: Error code 9 for command: ios-deploy with args: --justlaunch,--no-wifi,-d,-b,/Users/shaz/Desktop/f/platforms/ios/build/device/f.app

shazron · 2016-04-05T21:45:13Z

Now I can't repro the hanging state anymore -- very strange.

akofman · 2016-04-05T22:17:52Z

Even with this line commented, it still hangs on my side :(

shazron · 2016-04-05T22:20:32Z

I've rebooted my computer, etc, and still can't get this issue to repro, when I could before. I did have a fresh install of Xcode 7.3 hours ago, not sure what changed in the interim (did it install something in the background?)

akofman · 2016-04-05T22:25:00Z

Without any changes in the code ?

shazron · 2016-04-05T22:25:23Z

Yes, no changes.

akofman · 2016-04-05T22:35:45Z

And you're still using an ios 9.3 ?? WTH

shazron · 2016-04-05T22:36:59Z

I see in the Xcode 7.3 Release Notes: "Debugging can hang on launch if an .lldbinit file is present that tries to call quit in Python code during debugger initialization. (24360903)"
-- we don't use an .lldbinit file but we do send commands through lldb -s [lldb_command_file] which is is similar to lldbinit, but our initialization code doesn't call quit however

shazron · 2016-04-05T22:38:20Z

@akofman Nothing has changed. I will have to try tonight on another computer. The code is the same, so it has to be my "environment" somehow.

akofman · 2016-04-05T22:40:17Z

Did you check if your lldb version has been changed ? XCode 7.3 (7D175) => lldb-350.0.21.3

shazron · 2016-04-05T22:43:37Z

No change, it's XCode 7.3 (7D175) => lldb-350.0.21.3

hackjutsu · 2016-04-05T23:11:05Z

Guys, I wish I could help but I am stuck with a python error ImportError: No module named six when running ios-deploy with Xcode 7.3.

shazron · 2016-04-05T23:32:07Z

@hackjustu that's strange, ios-deploy does not import any module named "six" at all, I believe everything is standard lib

shazron · 2016-04-05T23:37:12Z

@hackjustu Seems it's one of the lldb python init files
https://bugs.swift.org/browse/SR-1061 which contains this link http://hastebin.com/obihaxujep.rb

omefire · 2016-04-06T17:39:00Z

@shazron Trying it out ...

shazron · 2016-04-06T18:08:28Z

Update: I didn't have time to write my results before I left, but I did more testing after my last statement, and I could eventually repro if I ran the command immediately again after a successful quit. It's sporadic. When running, ios-deploy should have two processes, plus one lldb process. "killall ios-deploy" and "killall lldb" to have a clean slate.

The essential problem is, lldb is not exiting, thus ios-deploy cannot exit as well.

akofman · 2016-04-06T18:57:52Z

It's really weird you're not able to reproduce it like before. In my case, it hangs every time we try to detach the app from the debugger.
Watching this repo I noticed that this Detach method try to get a mutex, and I think the mutex is already locked.

As an example If I add a log after this line, it will never be printed.

What do you think ?

hackjutsu · 2016-04-06T21:44:56Z

@akofman Did you actually get eStateRunning? I met a situation when state was always eStateLaunching and the process got stuck in the while loop. (Xcode 7.2 + iOS 8)

shazron · 2016-04-06T21:55:56Z

@akofman doing a blame those lines are from years ago, and would probably be in Xcode 7.2. I'm trying to look at commits from 2015 https://github.com/llvm-mirror/lldb/commits/master/source/API/SBProcess.cpp

shazron · 2016-04-06T21:57:56Z

trying to find changes since lldb-340.4.119.1 - not sure how that is tagged

shazron · 2016-04-06T22:32:28Z

I believe I found the culprit. I'm on a different computer and I can repro reliably. It's not ios-deploy or lldb, it appears to be how cordova is calling ios-deploy. See if you can repro my results.

Make sure you have the latest ios-deploy and cordova and Xcode 7.3:

npm install -g ios-deploy
npm install -g cordova

Create a new Cordova project with the iOS platform:

cordova create f f f
cd f
cordova platform add ios
cordova build
cordova run --device <-- this will hang
ios-deploy -d -b platforms/ios/build/device/f.app --justlaunch <-- this will not hang

I've tried it a lot of times, with the results above. Make sure you do a killall ios-deploy && killall lldb between the alternate runs.

Perhaps cordova's usage of nodejs' child_process may be the culprit:

akofman · 2016-04-07T07:33:34Z

@hackjustu: yep I get the eStateRunning. If I add a log before process.Detach(), it is well printed while the log after is never.

@shazron :
It doesn't change anything on my side :(
ios-deploy -d -b platforms/ios/build/device/f.app --justlaunch always hangs.

I just noticed you're using ios 9.3.1 and I'm using ios 9.3. I'm going to update my iPad and check again.

akofman · 2016-04-07T07:59:25Z

It is the same using ios 9.3.1.
An other point is that I'm testing on an iPad mini A1432.

akofman · 2016-04-07T08:07:35Z

If I add a quite long sleep before detaching the process, it works. But it needs like a sleep of 20s.
And at least I can see the log indicating the process is well detached :

(lldb) safequit
Process 238 detached

akofman · 2016-04-07T13:16:02Z

Ok. So I investigated a little bit more. It looks like without the waitForEvent method, everything works well and detaching the process doesn't hang anymore.
Regarding this part, I don't really understand why we are trying to retrieve the state from the event.
@shazron ? Maybe it is a legacy fix for older usecases, I never managed to go through this part of the code.

So I just removed all this part and simply get the state of the process from ... the process himself => akofman@4400067

I tested it on ios 9.3, ios 9.3.2 and ios 8.1 using ios-deploy -d -b App.app --justlaunch
and cordova run ios --device. it works well and quickly for both.

@omefire: could you have a try ?

shazron · 2016-04-07T17:25:11Z

@akofman I'm not sure. The commit is here perhaps @senthilmanick can comment since I merged it in from his implementation.

akofman · 2016-04-07T17:43:42Z

Yep, would be nice to have an explanation from the commiter :)
Else did you test it from your device ?

shazron · 2016-04-09T00:46:53Z

Is this superseded by #223 now? :)

akofman · 2016-04-11T07:33:35Z

I think yes. @hackjustu agree ?

hackjutsu · 2016-04-11T07:46:57Z

Yes, even the run_command fails, it won't hang now thanks to #223.

enhancement on python run_command

9c248b8

1. the python script should move forward only if it launches the app successfully

hackjutsu mentioned this pull request Mar 24, 2016

ios-deploy --justlaunch hangs #189

Closed

omefire mentioned this pull request Apr 4, 2016

CB-10962 CB-10945 removes justlaunch flag waiting for a fix in ios-deploy apache/cordova-ios#212

Closed

shazron mentioned this pull request Apr 8, 2016

ios-deploy tries to use "Latest" developer disk image for old iOS versions #221

Closed

6 tasks

shazron closed this Apr 11, 2016

hackjutsu mentioned this pull request Apr 12, 2016

Fixes #219 - iOS 9.3 app hangs on splash screen #223

Closed

enhancement on python run_command #218

enhancement on python run_command #218

Uh oh!

Conversation

hackjutsu commented Mar 24, 2016

Uh oh!

omefire commented Apr 4, 2016

Uh oh!

akofman commented Apr 4, 2016

Uh oh!

hackjutsu commented Apr 4, 2016

Uh oh!

akofman commented Apr 4, 2016

Uh oh!

omefire commented Apr 4, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

akofman commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

hackjutsu commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

shazron commented Apr 5, 2016

Uh oh!

omefire commented Apr 6, 2016

Uh oh!

shazron commented Apr 6, 2016

Uh oh!

akofman commented Apr 6, 2016

Uh oh!

hackjutsu commented Apr 6, 2016

Uh oh!

shazron commented Apr 6, 2016

Uh oh!

shazron commented Apr 6, 2016

Uh oh!

shazron commented Apr 6, 2016

Uh oh!

akofman commented Apr 7, 2016

Uh oh!

akofman commented Apr 7, 2016

Uh oh!