Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log device information #255

Closed
wants to merge 3 commits into from
Closed

Log device information #255

wants to merge 3 commits into from

Conversation

janpio
Copy link

@janpio janpio commented Apr 15, 2019

Adds 3 log calls before handing over to simctl to do the actual launching.

Part of #254

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #255 into master will decrease coverage by 0.83%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   85.85%   85.01%   -0.84%     
==========================================
  Files           9        9              
  Lines         304      307       +3     
  Branches       55       55              
==========================================
  Hits          261      261              
- Misses         32       35       +3     
  Partials       11       11
Impacted Files Coverage Δ
src/commands/launch.js 30% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6e3ba...2f81231. Read the comment docs.

@janpio janpio marked this pull request as ready for review April 16, 2019 15:24
@shazron shazron closed this Mar 3, 2020
@shazron
Copy link

shazron commented Mar 3, 2020

hmm can't reopen to re-trigger the CI. it couldn't have been merged anyway because the PR repo was deleted.

@janpio
Copy link
Author

janpio commented Mar 5, 2020

it couldn't have been merged anyway because the PR repo was deleted.

That doesn't make a difference to Github UI, but 🤷‍♀ . Not that important.

@shazron
Copy link

shazron commented Mar 6, 2020

it does make a difference, it disables the merge button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants