Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting the proper way to contributing #15

Closed
habpygo opened this issue Nov 24, 2017 · 10 comments
Closed

Documenting the proper way to contributing #15

habpygo opened this issue Nov 24, 2017 · 10 comments
Assignees

Comments

@habpygo
Copy link

habpygo commented Nov 24, 2017

Hi there.
After forking the repository on GitHub and cloning it locally all the go files point to the wrong package, i.e. giota, while the folder in which they reside is iota.lib.go. Could we somehow document how to contribute to the IOTA Go API? I would like to add functionality to use the lib to send MAM's to the tangle.

@knarz knarz self-assigned this Nov 24, 2017
@ghost
Copy link

ghost commented Dec 16, 2017

this project is dead, don't bother contributing

@jdevelop
Copy link

@0x13A mind to elaborate on "this project is dead"?

@jpolack
Copy link

jpolack commented Dec 27, 2017

@habpygo would love to see this!
I started with IOTA some days ago and would prefer contributing here if I had more information how I can start and where I can help

this project is dead, don't bother contributing

I would love to see this repository alive again since golang might go very well with IOT in general 👍

@habpygo
Copy link
Author

habpygo commented Dec 28, 2017

@jpolack hi,

Sorry for responding late. OK, super that you want to contribute.

Just to make sure, I took it that @0x13A meant by “this project” the iota.lib.go and that’s not for me to comment on since the project is maintained by @knarz — although I don’t believe this project is dead.
If by “this project” he means ‘using functionality to send MAM’s to the tangle’ he is wrong.

Unfortunately the testing is difficult, because IOTA org takes test nodes off-line that they promised would remain up there for testing. You can download the necessary files from http://iotameetup.nl but you will note that the provided testnode https://testnet140.tangle.works is not in the air anymore.

If you have a working testnode or know one, please let me know so we can continue working on a Golang MAM implementation.

@jpolack
Copy link

jpolack commented Dec 28, 2017

@habpygo
When I tried to run this project I used lightwallet server from http://iotasupport.com/lightwallet.shtml
f.e. http://eugeneoldisoft.iotasupport.com:14265.

I am not sure if I get everything clear here since there are some questions about the golang-implementation and the api-usage in general.
It would be awesome if you would find me on iota's-slack channel so we can clarify everything and find things I can start on. My nickname is simply "Jonah" .

A Golang MAM implementation would be nice!

@jeffwillette
Copy link
Contributor

@jpolack, could you send me a slack invite? all of the ones I see are dead. I too am interested in contributing here and getting a golang implementation working

@habpygo
Copy link
Author

habpygo commented Jan 7, 2018

Hi @deltaskelta You don't need an invite according te me; just sign in to Slack and subscribe to iotatangle and the different channels. You can communicate with us via DMs.

@jpolack
Copy link

jpolack commented Jan 8, 2018

Hey @deltaskelta that is nice to hear!
You find all important links (slack aswell) here: http://www.iotaindex.com/

I worked with @habpygo on MamgoIota which we are now trying to merge here #28. Sadly @knarz seems to be inactive and does neither accept that pull request nor invite one of us to take care of this repo.

I think the best way to start is if you try to run MamgoIota and write us a message as soon as you entered slack 😁

@jeffwillette
Copy link
Contributor

@jpolack I'll check out mamgoiota as soon as possible. I've been writing Golang for a long time but I need to get more acquainted with the iota system and how all the pieces of the engine work.

See you in slack

@luca-moser
Copy link
Member

Please see the new instructions under the next branch.

luca-moser added a commit that referenced this issue Jan 30, 2019
# This is the 1st commit message:

adds account base impl.

# This is the commit message #2:

fixes SendTrytes() returning reversed bundle

let DoPoW() return trytes in bundle order

fixes AttachToTangle reversing already reversed trytes

# This is the commit message #3:

adds base implementation

# This is the commit message #4:

adds some todos

# This is the commit message #5:

makes addPendingTransfer also store the spent address indices, removes action channels by only using one, adds multi send, removes LastDepositAddress()

# This is the commit message #6:

moves account package

# This is the commit message #7:

adds clean shutdown, precomputed next dep. address, errors channel for internal errors

# This is the commit message #8:

changes state schema, adds promotion/reattachment

# This is the commit message #9:

smh

# This is the commit message #10:

adds deposit requests/conditions

# This is the commit message #11:

fixes tests

# This is the commit message #12:

split packages, make badger use gob instead of json

# This is the commit message #13:

removes SendMulti, makes Send take a variadic parameter

# This is the commit message #14:

fixes tests, reduces to single Send function, splits top level account files

# This is the commit message #15:

implements quorum based querying of nodes

# This is the commit message #16:

switch to xxhash for res body, make primary node optional

# This is the commit message #17:

moves generating hash before lock

# This is the commit message #18:

adds no response tolerance to quorum settings

# This is the commit message #19:

subtract error count from total votes

# This is the commit message #20:

fixes no-response tolerance, adds more descriptive error message

# This is the commit message #21:

adds override for commands to execute in quorum

# This is the commit message #22:

adds quorumable latest subtangle milestone query

# This is the commit message #23:

adds customizable defaults for certain calls where no quorum was reached

# This is the commit message #24:

simplify injectDefault

# This is the commit message #25:

adds partial test

# This is the commit message #26:

fixes some typos, adds additional test for explicit error responses

# This is the commit message #27:

adds UsableBalance()/TotalBalance()

# This is the commit message #28:

refactor input selection, wrap errors with more descriptive messages

# This is the commit message #29:

adds specific checks when querying the latest solid subtangle milestone

# This is the commit message #30:

fixes typo

# This is the commit message #31:

adds safe component update to account, adds special treatment for quorum findTransactions call

# This is the commit message #32:

fixes non receive events to be not fired until first poll went through

# This is the commit message #33:

modulerizes events out of the account object, adds builder pattern for creating accounts and event listeners

# This is the commit message #34:

changes store interface to return maps, optimizes pertail receive event filter, optimizes event listener registration

# This is the commit message #35:

adds correct addr gen. cancellation,fixes receive events being dropped, fixes duplicated receive events for messages
luca-moser added a commit that referenced this issue Jan 30, 2019
# This is the 1st commit message:

adds account base impl.

# This is the commit message #2:

fixes SendTrytes() returning reversed bundle

let DoPoW() return trytes in bundle order

fixes AttachToTangle reversing already reversed trytes

# This is the commit message #3:

adds base implementation

# This is the commit message #4:

adds some todos

# This is the commit message #5:

makes addPendingTransfer also store the spent address indices, removes action channels by only using one, adds multi send, removes LastDepositAddress()

# This is the commit message #6:

moves account package

# This is the commit message #7:

adds clean shutdown, precomputed next dep. address, errors channel for internal errors

# This is the commit message #8:

changes state schema, adds promotion/reattachment

# This is the commit message #9:

smh

# This is the commit message #10:

adds deposit requests/conditions

# This is the commit message #11:

fixes tests

# This is the commit message #12:

split packages, make badger use gob instead of json

# This is the commit message #13:

removes SendMulti, makes Send take a variadic parameter

# This is the commit message #14:

fixes tests, reduces to single Send function, splits top level account files

# This is the commit message #15:

implements quorum based querying of nodes

# This is the commit message #16:

switch to xxhash for res body, make primary node optional

# This is the commit message #17:

moves generating hash before lock

# This is the commit message #18:

adds no response tolerance to quorum settings

# This is the commit message #19:

subtract error count from total votes

# This is the commit message #20:

fixes no-response tolerance, adds more descriptive error message

# This is the commit message #21:

adds override for commands to execute in quorum

# This is the commit message #22:

adds quorumable latest subtangle milestone query

# This is the commit message #23:

adds customizable defaults for certain calls where no quorum was reached

# This is the commit message #24:

simplify injectDefault

# This is the commit message #25:

adds partial test

# This is the commit message #26:

fixes some typos, adds additional test for explicit error responses

# This is the commit message #27:

adds UsableBalance()/TotalBalance()

# This is the commit message #28:

refactor input selection, wrap errors with more descriptive messages

# This is the commit message #29:

adds specific checks when querying the latest solid subtangle milestone

# This is the commit message #30:

fixes typo

# This is the commit message #31:

adds safe component update to account, adds special treatment for quorum findTransactions call

# This is the commit message #32:

fixes non receive events to be not fired until first poll went through

# This is the commit message #33:

modulerizes events out of the account object, adds builder pattern for creating accounts and event listeners

# This is the commit message #34:

changes store interface to return maps, optimizes pertail receive event filter, optimizes event listener registration

# This is the commit message #35:

adds correct addr gen. cancellation,fixes receive events being dropped, fixes duplicated receive events for messages

# This is the commit message #36:

adds the concepts of plugins, makes promoter and transfer polling plugins, simplfies event machine

# This is the commit message #37:

store signatures too

# This is the commit message #38:

only store non empty signatures

# This is the commit message #39:

resolves conflicts of cherry pick

# This is the commit message #40:

dont generete addr. checksum at unnedded places, omit empty CDR fields in marshaling

# This is the commit message #41:

fixes checkConsistency for quorum, optimizes input selection, replaces event loop with RW lock, fixes promoter not having a time source, fixes transfer poller not shutting down, fixes tests, renames input selection func., optimizes request parsing of IRI calls

# This is the commit message #42:

changes pending transfer data to trytes, fixes reattacher creating inconsistent bundles, fixes primary CDRs with 0 balance being removed

# This is the commit message #43:

adjusts to latest spec

# This is the commit message #44:

adjusts json field tag for CDRs, fixes typo in plugins

# This is the commit message #45:

adds oracle package

# This is the commit message #46:

moves store impls. into own pkgs

# This is the commit message #47:

fixes gocks and removes quorum code from branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants