Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] added dependency management #21

Closed
wants to merge 4 commits into from
Closed

[feature] added dependency management #21

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2017 •
edited by ghost
Loading

Added golang/dep dependency management

@knarz
Copy link
Contributor

knarz commented Dec 11, 2017

I appreciate the effort but seeing as this is supposed to be a library I'm against including the vendor directory in the repo.

@ghost
Copy link
Author

ghost commented Dec 11, 2017

@knarz having the vendor folder into the repository is commonly advised as good practice in the Golang ecosystem, however not strictly, here some pro/cons from https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory

Pros

  • It's the only way to get truly reproducible builds, as it guards against upstream renames, deletes and commit history overwrites.
  • You don't need an extra dep ensure step to sync vendor/ with Gopkg.lock after most operations, such as go get, cloning, getting latest, merging, etc.

Cons

  • Your repo will be bigger, potentially a lot bigger, though prune can help minimize this problem.
  • PR diffs will include changes for files under vendor/ when Gopkg.lock is modified, however files in vendor/ are hidden by default on Github.

What do you think?

@knarz
Copy link
Contributor

knarz commented Dec 12, 2017

I am aware of the pros and cons and agree that for applications that best practice should be followed but I think that libraries should let their users decide.

@ghost
Copy link
Author

ghost commented Dec 12, 2017

I am not sure what is your point, but I won't hang more on this, I've removed the vendor folder. It's not a big deal at the end. Thanks

@ghost
Copy link
Author

ghost commented Dec 13, 2017 •
edited by ghost
Loading

what do you think @knarz?

Closed due to no interest in incoming contributions/discussions

@ghost ghost closed this Dec 16, 2017
luca-moser added a commit that referenced this pull request Jan 30, 2019
@luca-moser
# This is a combination of 35 commits.
001fe98 
# This is the 1st commit message:

adds account base impl.

# This is the commit message #2:

fixes SendTrytes() returning reversed bundle

let DoPoW() return trytes in bundle order

fixes AttachToTangle reversing already reversed trytes

# This is the commit message #3:

adds base implementation

# This is the commit message #4:

adds some todos

# This is the commit message #5:

makes addPendingTransfer also store the spent address indices, removes action channels by only using one, adds multi send, removes LastDepositAddress()

# This is the commit message #6:

moves account package

# This is the commit message #7:

adds clean shutdown, precomputed next dep. address, errors channel for internal errors

# This is the commit message #8:

changes state schema, adds promotion/reattachment

# This is the commit message #9:

smh

# This is the commit message #10:

adds deposit requests/conditions

# This is the commit message #11:

fixes tests

# This is the commit message #12:

split packages, make badger use gob instead of json

# This is the commit message #13:

removes SendMulti, makes Send take a variadic parameter

# This is the commit message #14:

fixes tests, reduces to single Send function, splits top level account files

# This is the commit message #15:

implements quorum based querying of nodes

# This is the commit message #16:

switch to xxhash for res body, make primary node optional

# This is the commit message #17:

moves generating hash before lock

# This is the commit message #18:

adds no response tolerance to quorum settings

# This is the commit message #19:

subtract error count from total votes

# This is the commit message #20:

fixes no-response tolerance, adds more descriptive error message

# This is the commit message #21:

adds override for commands to execute in quorum

# This is the commit message #22:

adds quorumable latest subtangle milestone query

# This is the commit message #23:

adds customizable defaults for certain calls where no quorum was reached

# This is the commit message #24:

simplify injectDefault

# This is the commit message #25:

adds partial test

# This is the commit message #26:

fixes some typos, adds additional test for explicit error responses

# This is the commit message #27:

adds UsableBalance()/TotalBalance()

# This is the commit message #28:

refactor input selection, wrap errors with more descriptive messages

# This is the commit message #29:

adds specific checks when querying the latest solid subtangle milestone

# This is the commit message #30:

fixes typo

# This is the commit message #31:

adds safe component update to account, adds special treatment for quorum findTransactions call

# This is the commit message #32:

fixes non receive events to be not fired until first poll went through

# This is the commit message #33:

modulerizes events out of the account object, adds builder pattern for creating accounts and event listeners

# This is the commit message #34:

changes store interface to return maps, optimizes pertail receive event filter, optimizes event listener registration

# This is the commit message #35:

adds correct addr gen. cancellation,fixes receive events being dropped, fixes duplicated receive events for messages
luca-moser added a commit that referenced this pull request Jan 30, 2019
@luca-moser
# This is a combination of 47 commits.
fe03244 
# This is the 1st commit message:

adds account base impl.

# This is the commit message #2:

fixes SendTrytes() returning reversed bundle

let DoPoW() return trytes in bundle order

fixes AttachToTangle reversing already reversed trytes

# This is the commit message #3:

adds base implementation

# This is the commit message #4:

adds some todos

# This is the commit message #5:

makes addPendingTransfer also store the spent address indices, removes action channels by only using one, adds multi send, removes LastDepositAddress()

# This is the commit message #6:

moves account package

# This is the commit message #7:

adds clean shutdown, precomputed next dep. address, errors channel for internal errors

# This is the commit message #8:

changes state schema, adds promotion/reattachment

# This is the commit message #9:

smh

# This is the commit message #10:

adds deposit requests/conditions

# This is the commit message #11:

fixes tests

# This is the commit message #12:

split packages, make badger use gob instead of json

# This is the commit message #13:

removes SendMulti, makes Send take a variadic parameter

# This is the commit message #14:

fixes tests, reduces to single Send function, splits top level account files

# This is the commit message #15:

implements quorum based querying of nodes

# This is the commit message #16:

switch to xxhash for res body, make primary node optional

# This is the commit message #17:

moves generating hash before lock

# This is the commit message #18:

adds no response tolerance to quorum settings

# This is the commit message #19:

subtract error count from total votes

# This is the commit message #20:

fixes no-response tolerance, adds more descriptive error message

# This is the commit message #21:

adds override for commands to execute in quorum

# This is the commit message #22:

adds quorumable latest subtangle milestone query

# This is the commit message #23:

adds customizable defaults for certain calls where no quorum was reached

# This is the commit message #24:

simplify injectDefault

# This is the commit message #25:

adds partial test

# This is the commit message #26:

fixes some typos, adds additional test for explicit error responses

# This is the commit message #27:

adds UsableBalance()/TotalBalance()

# This is the commit message #28:

refactor input selection, wrap errors with more descriptive messages

# This is the commit message #29:

adds specific checks when querying the latest solid subtangle milestone

# This is the commit message #30:

fixes typo

# This is the commit message #31:

adds safe component update to account, adds special treatment for quorum findTransactions call

# This is the commit message #32:

fixes non receive events to be not fired until first poll went through

# This is the commit message #33:

modulerizes events out of the account object, adds builder pattern for creating accounts and event listeners

# This is the commit message #34:

changes store interface to return maps, optimizes pertail receive event filter, optimizes event listener registration

# This is the commit message #35:

adds correct addr gen. cancellation,fixes receive events being dropped, fixes duplicated receive events for messages

# This is the commit message #36:

adds the concepts of plugins, makes promoter and transfer polling plugins, simplfies event machine

# This is the commit message #37:

store signatures too

# This is the commit message #38:

only store non empty signatures

# This is the commit message #39:

resolves conflicts of cherry pick

# This is the commit message #40:

dont generete addr. checksum at unnedded places, omit empty CDR fields in marshaling

# This is the commit message #41:

fixes checkConsistency for quorum, optimizes input selection, replaces event loop with RW lock, fixes promoter not having a time source, fixes transfer poller not shutting down, fixes tests, renames input selection func., optimizes request parsing of IRI calls

# This is the commit message #42:

changes pending transfer data to trytes, fixes reattacher creating inconsistent bundles, fixes primary CDRs with 0 balance being removed

# This is the commit message #43:

adjusts to latest spec

# This is the commit message #44:

adjusts json field tag for CDRs, fixes typo in plugins

# This is the commit message #45:

adds oracle package

# This is the commit message #46:

moves store impls. into own pkgs

# This is the commit message #47:

fixes gocks and removes quorum code from branch
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@knarz