Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Mobile: Upgrade react-native-keychain to 3.0.0 #1180

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Mobile: Upgrade react-native-keychain to 3.0.0 #1180

merged 3 commits into from
Apr 16, 2019

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Mar 14, 2019 •
edited
Loading

Description

  • Upgrades react-native-keychain to 3.0.0
    • This includes various fixes for stability on Android
  • Backports iOS memory leak fix from 3.1.0

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested on iOS (dev)
  • Tested on Android (dev)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working C - Mobile E - Security Epic - Security related L - WIP Lifecycle - Work in Progress P2 - High Priority - Prefer to fix or merge this labels Mar 14, 2019
@rajivshah3 rajivshah3 self-assigned this Mar 14, 2019
@rajivshah3 rajivshah3 changed the title Mobile: Upgrade react-native-keychain to 3.1.1 [WIP] Mobile: Upgrade react-native-keychain to 3.1.1 Mar 14, 2019
@rajivshah3 rajivshah3 added P3 - Medium Priority - Normal priority and removed P2 - High Priority - Prefer to fix or merge this labels Mar 14, 2019
@rajivshah3 rajivshah3 changed the title [WIP] Mobile: Upgrade react-native-keychain to 3.1.1 [WIP] Mobile: Upgrade react-native-keychain to 3.0.0 Apr 7, 2019
@rajivshah3 rajivshah3 changed the title [WIP] Mobile: Upgrade react-native-keychain to 3.0.0 Mobile: Upgrade react-native-keychain to 3.0.0 Apr 7, 2019
@rajivshah3 rajivshah3 added L - Need reviews Lifecycle - Each PR must have at least two reviewers and removed L - WIP Lifecycle - Work in Progress labels Apr 7, 2019
@rajivshah3 rajivshah3 marked this pull request as ready for review April 7, 2019 21:14
cvarley100
cvarley100 reviewed Apr 12, 2019
View reviewed changes
src/mobile/patches/react-native-keychain+3.0.0.patch
diff --git a/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m b/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m
index 381981b..80d1d9f 100644
--- a/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m
+++ b/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this patch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes a memory leak on iOS (oblador/react-native-keychain#188). It was included in react-native-keychain@3.1.0 but that caused issues on Android, so I'm just patching it for now until we can migrate to 3.1.0.

@cvarley100 cvarley100 mentioned this pull request Apr 16, 2019
Merged
@rajivshah3 rajivshah3 merged commit 8905a7b into develop Apr 16, 2019
@rajivshah3 rajivshah3 deleted the chore/rn-keychain branch April 16, 2019 16:44
rajivshah3 added a commit that referenced this pull request Apr 23, 2019
@rajivshah3
Mobile: Upgrade react-native-keychain to 3.0.0 (#1180)
d71e63e 
* Mobile: Upgrade react-native-keychain to 3.0.0

* Mobile/iOS: Release foundTypeRefs when they are no longer being used

Applies patch from oblador/react-native-keychain#188
rajivshah3 added a commit that referenced this pull request Apr 23, 2019
@rajivshah3
Mobile: Upgrade react-native-keychain to 3.0.0 (#1180)
d169839 
* Mobile: Upgrade react-native-keychain to 3.0.0

* Mobile/iOS: Release foundTypeRefs when they are no longer being used

Applies patch from oblador/react-native-keychain#188
rihardsgravis pushed a commit that referenced this pull request Apr 23, 2019
@cvarley100 @rihardsgravis
Desktop: Update Windows 7 branch to latest (#1352)
90c131d 
* Bump electron from 3.1.6 to 3.1.8 in /src/desktop (#1294)

Bumps [electron](https://github.com/electron/electron) from 3.1.6 to 3.1.8.
- [Release notes](https://github.com/electron/electron/releases)
- [Commits](electron/electron@v3.1.6...v3.1.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* feat: make sure we do not reconstruct and validate stored reattachments (#1293)

* Mobile: Fix seed text input issues (#1291)

* Mobile: Remove push to mask and fix Android letter duplication

* Mobile: Remove unused textinput prop

* Auto-retry with increased timeout for attachToTangle & getTransactionsToApprove APIs (#1285)

* Mobile/iOS: Rebuild Entangled framework (#1280)

Ref: rajivshah3/entangled@b246438

* Mobile/Android: Rebuild Entangled libs (#1281)

Ref: iotaledger/entangled@771bb1e

* Bump @babel/plugin-proposal-object-rest-spread in /src/desktop (#1305)

Bumps [@babel/plugin-proposal-object-rest-spread](https://github.com/babel/babel) from 7.4.0 to 7.4.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.4.0...v7.4.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump webpack-cli from 3.2.3 to 3.3.0 in /src/desktop (#1304)

Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.2.3 to 3.3.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](webpack/webpack-cli@V.3.2.3...v.3.3.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump mini-css-extract-plugin from 0.5.0 to 0.6.0 in /src/desktop (#1295)

Bumps [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/mini-css-extract-plugin@v0.5.0...v0.6.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump @babel/register from 7.0.0 to 7.4.0 in /src/desktop (#1297)

Bumps [@babel/register](https://github.com/babel/babel) from 7.0.0 to 7.4.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.0.0...v7.4.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Mobile: Use native dropdown component (#1275)

* Shared: Remove 2FA from all versions (#1292)

* Mobile: Remove 2FA

* Shared: Remove 2FA strings and actions/reducers

* Desktop: Remove 2fa

* Desktop: Revert shrinkwrap changes

* Desktop: Add initVault method

* Update lockfiles

* New Crowdin translations (#1277)

* New translations translation.json (Polish)

* New translations translation.json (Polish)

* New translations translation.json (Croatian)

* New translations translation.json (German)

* New translations translation.json (Croatian)

* New translations translation.json (Japanese)

* New translations translation.json (Japanese)

* New translations translation.json (Swedish)

* New translations translation.json (Swedish)

* Mobile: Fix navigation crash (#1308)

* Shared: Rebuild icon font file (#1309)

* Shared: Rebuild icon file

* Mobile: Replace Android icon file

* New Crowdin translations (#1307)

* New translations translation.json (Bulgarian)

* New translations translation.json (Spanish, Latin America)

* New translations translation.json (Vietnamese)

* New translations translation.json (Urdu (Pakistan))

* New translations translation.json (Thai)

* New translations translation.json (Turkish)

* New translations translation.json (Tamil)

* New translations translation.json (Finnish)

* New translations translation.json (Estonian)

* New translations translation.json (Dutch)

* New translations translation.json (Danish)

* New translations translation.json (Czech)

* New translations translation.json (Croatian)

* New translations translation.json (Chinese Traditional)

* New translations translation.json (Arabic)

* New translations translation.json (Swedish)

* New translations translation.json (Georgian)

* New translations translation.json (Polish)

* New translations translation.json (Korean)

* New translations translation.json (German)

* New translations translation.json (Chinese Simplified)

* New translations translation.json (French)

* New translations translation.json (German, Switzerland)

* New translations translation.json (Spanish)

* New translations translation.json (Norwegian)

* New translations translation.json (Slovenian)

* New translations translation.json (Slovak)

* New translations translation.json (Serbian (Latin))

* New translations translation.json (Russian)

* New translations translation.json (Romanian)

* New translations translation.json (Portuguese, Brazilian)

* New translations translation.json (Portuguese)

* New translations translation.json (Persian)

* New translations translation.json (Lithuanian)

* New translations translation.json (Greek)

* New translations translation.json (Latvian)

* New translations translation.json (Kannada)

* New translations translation.json (Japanese)

* New translations translation.json (Italian)

* New translations translation.json (Indonesian)

* New translations translation.json (Hungarian)

* New translations translation.json (Hindi)

* New translations translation.json (Hebrew)

* chore: disable redux-logger by default (#1310)

* Mobile: Fix SeedVault export name (#1312)

* Mobile: Fix unit info modal theming (#1311)

* Bump snyk from 1.150.0 to 1.151.0 (#1320)

* Bump i18next from 15.0.4 to 15.0.9 in /src/desktop (#1321)

* Bump prettier from 1.11.0 to 1.16.4 (#1248)

* Bump eslint-plugin-import from 2.16.0 to 2.17.1 (#1318)

* Desktop: Show modal for Ledger udev errors (#1192)

* Desktop: Show modal for Ledger udev errors

* Desktop: Localize udev error strings

* - Switch to link element for Ledger support url
- Add back to Seed intro button to udeverror popup

* Bump keytar from 4.4.0 to 4.4.1 in /src/desktop (#1316)

Bumps [keytar](https://github.com/atom/node-keytar) from 4.4.0 to 4.4.1.
- [Release notes](https://github.com/atom/node-keytar/releases)
- [Commits](atom/node-keytar@v4.4.0...v4.4.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump webpack from 4.29.6 to 4.30.0 in /src/desktop (#1317)

Bumps [webpack](https://github.com/webpack/webpack) from 4.29.6 to 4.30.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v4.29.6...v4.30.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump react-router-dom from 4.3.1 to 5.0.0 in /src/desktop (#1319)

Bumps [react-router-dom](https://github.com/ReactTraining/react-router) from 4.3.1 to 5.0.0.
- [Release notes](https://github.com/ReactTraining/react-router/releases)
- [Commits](remix-run/react-router@v4.3.1...v5.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Fix Linux icon path (#1322)

* Shared: Fix realm schema migration (#1326)

* New Crowdin translations (#1314)

* New translations translation.json (German)

* New translations translation.json (German)

* New translations translation.json (German)

* New translations translation.json (Portuguese, Brazilian)

* New translations translation.json (Portuguese, Brazilian)

* New translations translation.json (Polish)

* New translations translation.json (Croatian)

* New translations translation.json (Bulgarian)

* New translations translation.json (Spanish, Latin America)

* New translations translation.json (Vietnamese)

* New translations translation.json (Urdu (Pakistan))

* New translations translation.json (Thai)

* New translations translation.json (Turkish)

* New translations translation.json (Tamil)

* New translations translation.json (Finnish)

* New translations translation.json (Estonian)

* New translations translation.json (Dutch)

* New translations translation.json (Danish)

* New translations translation.json (Czech)

* New translations translation.json (Croatian)

* New translations translation.json (Chinese Traditional)

* New translations translation.json (Arabic)

* New translations translation.json (Swedish)

* New translations translation.json (Georgian)

* New translations translation.json (Polish)

* New translations translation.json (Korean)

* New translations translation.json (German)

* New translations translation.json (Chinese Simplified)

* New translations translation.json (French)

* New translations translation.json (German, Switzerland)

* New translations translation.json (Spanish)

* New translations translation.json (Norwegian)

* New translations translation.json (Slovenian)

* New translations translation.json (Slovak)

* New translations translation.json (Serbian (Latin))

* New translations translation.json (Russian)

* New translations translation.json (Romanian)

* New translations translation.json (Portuguese, Brazilian)

* New translations translation.json (Portuguese)

* New translations translation.json (Persian)

* New translations translation.json (Lithuanian)

* New translations translation.json (Greek)

* New translations translation.json (Latvian)

* New translations translation.json (Kannada)

* New translations translation.json (Japanese)

* New translations translation.json (Italian)

* New translations translation.json (Indonesian)

* New translations translation.json (Hungarian)

* New translations translation.json (Hindi)

* New translations translation.json (Hebrew)

* New translations translation.json (Italian)

* New translations translation.json (Japanese)

* New translations translation.json (Polish)

* Mobile: Upgrade react-native-keychain to 3.0.0 (#1180)

* Mobile: Upgrade react-native-keychain to 3.0.0

* Mobile/iOS: Release foundTypeRefs when they are no longer being used

Applies patch from oblador/react-native-keychain#188

* Mobile: Fix password fields crash (#1328)

* Mobile: Bump build no to 54 (#1325)

* Bump react-dom from 16.8.2 to 16.8.6 in /src/desktop (#1335)

Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) from 16.8.2 to 16.8.6.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v16.8.6/packages/react-dom)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump @babel/plugin-proposal-class-properties in /src/desktop (#1332)

Bumps [@babel/plugin-proposal-class-properties](https://github.com/babel/babel) from 7.3.3 to 7.4.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.3.3...v7.4.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump dart-sass from 1.17.2 to 1.18.0 in /src/desktop (#1331)

Bumps [dart-sass](https://github.com/sass/dart-sass) from 1.17.2 to 1.18.0.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](sass/dart-sass@1.17.2...1.18.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump kdbxweb from 1.2.6 to 1.2.7 in /src/desktop (#1333)

Bumps [kdbxweb](https://github.com/keeweb/kdbxweb) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/keeweb/kdbxweb/releases)
- [Changelog](https://github.com/keeweb/kdbxweb/blob/master/release-notes.md)
- [Commits](keeweb/kdbxweb@1.2.6...1.2.7)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump eslint-plugin-import from 2.17.1 to 2.17.2 (#1337)

* Desktop: Trigger notifications for new transactions only (#1323)

* Desktop: Check for valid SeedVault file format (#1324)

* Check for valid SeedVault file format on import

* Fix string name formatting

* Bump snyk from 1.151.0 to 1.151.1 (#1345)

* Desktop: Update shrinkwrap (#1343)

* Bump react-markdown from 4.0.6 to 4.0.8 in /src/desktop (#1347)

Bumps [react-markdown](https://github.com/rexxars/react-markdown) from 4.0.6 to 4.0.8.
- [Release notes](https://github.com/rexxars/react-markdown/releases)
- [Changelog](https://github.com/rexxars/react-markdown/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rexxars/react-markdown/commits/v4.0.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump react from 16.8.3 to 16.8.6 in /src/desktop (#1346)

Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 16.8.3 to 16.8.6.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v16.8.6/packages/react)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump react-transition-group from 2.9.0 to 4.0.0 in /src/desktop (#1349)

Bumps [react-transition-group](https://github.com/reactjs/react-transition-group) from 2.9.0 to 4.0.0.
- [Release notes](https://github.com/reactjs/react-transition-group/releases)
- [Changelog](https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md)
- [Commits](reactjs/react-transition-group@v2.9.0...v4.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Desktop: Update README.md (#1338)

* Update README.md

* Update README.md
@snyk-bot snyk-bot mentioned this pull request Apr 14, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cvarley100 cvarley100 cvarley100 approved these changes

@laumair laumair Awaiting requested review from laumair

Assignees

@rajivshah3 rajivshah3

Labels
C - Mobile E - Security Epic - Security related L - Need reviews Lifecycle - Each PR must have at least two reviewers P3 - Medium Priority - Normal priority T - Bug Type - Bug: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajivshah3 @cvarley100