Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement submit tx API #54

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Implement submit tx API #54

merged 1 commit into from
Apr 2, 2020

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Mar 17, 2020

Resolves #48

Provide tx must be in base64 format. Otherwise tendermint cries 😭

@orkunkl orkunkl marked this pull request as ready for review April 2, 2020 11:08
Copy link
Contributor

@davepuchyr davepuchyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @orkunkl!

Copy link

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if this logging message is intentional or not. But anyways, LGTM.

@orkunkl
Copy link
Contributor Author

orkunkl commented Apr 2, 2020

Don't know if this logging message is intentional or not. But anyways, LGTM.

Nope it is not. But I will improve logging as next task anyways. We can merge this now.

@orkunkl orkunkl merged commit 9de5761 into master Apr 2, 2020
@orkunkl orkunkl deleted the submit-tx-api branch April 2, 2020 16:22
orkunkl added a commit that referenced this pull request Apr 3, 2020
* Implement list msgfee API; Implement ABCIPrefixQuery (#50)

* Implement ABCIPrefixQuery

* Implement msgfee api

* Generate swagger docs

* Implement ABCIPrefixQuery

* Implement msgfee api

* Generate swagger docs

* Fix test

* Improve docs

* Apply review recommendations

* Organize readme (#52)

* Add dockerize swagger docs generation (#53)

* Implement nonce api (#51)

* Implement get nonce with address API

* Implement get nonce with pubkey  API

* Apply review recommendations

* Implement ABCIKeyQueryIter (#58)

* Return multiple username on /username/owner (#59)

* Implement integration tests (#61)

* Prepare integration test code

* Add travis script; Edit readme

* Multisig contract it

* Fix multisig/contracts api; add it tests for the api

* Test EscrowEscrows handler

* Move testing tools to bnsapitest

* Fix escrow escrows test and handler

* Add ExtractOffsetFromParam func

* Add todo

* Refactor bns client and fix tests

* Delete hard coded testnet url

* Import dec and enc functions from bnscli

* Add new tests

* Implement ID tests

* Run go mod tidy

* Fix client

* Fix offset logic and queries

* Update docs

* Fix account owner test

* Implement tx submit endpoint (#54)

* Delete sub directories under handlers and move all to root (#62)

* Add username/resolve; delete static tendermint ip

* AccountResolveHandler rename; add endpoints to default handler

* Sync weave 0.21.x with master

* Downgrade tendermint and weave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send signed transactions through bnsapi
3 participants