Implement integration tests #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some handlers need fine-tuning with parameter formats. Things to discuss:
|
orkunkl
force-pushed
the
integration-test
branch
from
89eabbd
to
62a1ece
Compare
davepuchyr
approved these changes
Apr 2, 2020
orkunkl
added a commit
that referenced
this pull request
Apr 3, 2020
* Implement list msgfee API; Implement ABCIPrefixQuery (#50) * Implement ABCIPrefixQuery * Implement msgfee api * Generate swagger docs * Implement ABCIPrefixQuery * Implement msgfee api * Generate swagger docs * Fix test * Improve docs * Apply review recommendations * Organize readme (#52) * Add dockerize swagger docs generation (#53) * Implement nonce api (#51) * Implement get nonce with address API * Implement get nonce with pubkey API * Apply review recommendations * Implement ABCIKeyQueryIter (#58) * Return multiple username on /username/owner (#59) * Implement integration tests (#61) * Prepare integration test code * Add travis script; Edit readme * Multisig contract it * Fix multisig/contracts api; add it tests for the api * Test EscrowEscrows handler * Move testing tools to bnsapitest * Fix escrow escrows test and handler * Add ExtractOffsetFromParam func * Add todo * Refactor bns client and fix tests * Delete hard coded testnet url * Import dec and enc functions from bnscli * Add new tests * Implement ID tests * Run go mod tidy * Fix client * Fix offset logic and queries * Update docs * Fix account owner test * Implement tx submit endpoint (#54) * Delete sub directories under handlers and move all to root (#62) * Add username/resolve; delete static tendermint ip * AccountResolveHandler rename; add endpoints to default handler * Sync weave 0.21.x with master * Downgrade tendermint and weave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to iov-one/weave#1183
The integration test runs the tests using a live blockchain and compares the results to the saved ones. This test cannot be run on every release or build since the data in the chain will change constantly. We can run a testing chain that contains fairly constant data and test it against that. But I think this PR is done for now. @davepuchyr can you take a look at it tests and tell me if we need more testing on any handler.
This PR is quite big because I fixed code on the way.