This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Add key api from go-ipfs #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Muré <batolettre@gmail.com>
|
Fixed the dangling comma. I don't think I'm to blame for the remaining test fail. |
|
@diasdavid Is it planned to support the key api here ? I'd like to avoid using a fork. If yes I can make a better PR. |
|
Thank you @MichaelMure. The goal is to support the whole api that go exposes in this library. It would be great if you could a test for the new method. |
|
@dignifiedquire what about interface-ipfs-core ? It needs to be properly spec-ed to go there and the api in go-ipfs and here will be adjusted later ? |
Signed-off-by: Michael Muré <batolettre@gmail.com>
Signed-off-by: Michael Muré <batolettre@gmail.com>
|
I don't think we will need this to be part of the main interface library, it will be eventually exposed directly through .crypto. Meanwhile this PR looks good, merging it in :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed that for my project so maybe it's useful for you as well :)