This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Use a different remote server for test #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
The previous server had issues, so the test timed out. Hopefully this on is more stable.
|
Some tests fail, but at least not the |
daviddias
reviewed
Mar 9, 2018
|
|
||
| it('.urlAdd http with redirection', (done) => { | ||
| ipfs.util.addFromURL('http://covers.openlibrary.org/book/id/969165.jpg', (err, result) => { | ||
| ipfs.util.addFromURL('https://coverartarchive.org/release/6e2a1694-d8b9-466a-aa33-b1077b2333c1', (err, result) => { |
There was a problem hiding this comment.
@vmx can we use one file used from the ipfs gateway?
There was a problem hiding this comment.
If you give me a link, for sure.
I don't know how to find URLs that redirect. I wanted a quick solution to the problem. The real fix would be one that doesn't need an Internet connection at all, but that's out of scope for me atm.
There was a problem hiding this comment.
nvm. Missed the need for a redirect :)
Closed
|
For comparison. With this pull request, this test didn't fail: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/detail/PR-711/4/tests |
daviddias
approved these changes
Mar 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous server had issues, so the test timed out. Hopefully
this on is more stable.