Skip to content

Conversation

meyer1994
Copy link
Contributor

I am not sure if I did this correctly. I still do not understand some parts of the code. There are lots of backawards compatibility stuff that I do not know (yet).

@meyer1994 meyer1994 mentioned this pull request Sep 7, 2020
Copy link
Contributor

@ntninja ntninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs for the new parameters, otherwise LGTM!

(I'm currently a bit busy, so feel free to add the comments, otherwise I'll do when I merge this.)

I just copied from `ipfs dag put --help`
@ntninja ntninja merged commit ee290db into ipfs-shipyard:master Sep 24, 2020
@ntninja
Copy link
Contributor

ntninja commented Sep 24, 2020

Thanks!

@meyer1994 meyer1994 deleted the dagputargs branch September 24, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants