Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aegir check-project updates README.md with incorrect repo for issues link #1056

Closed
SgtPooki opened this issue Aug 23, 2022 · 1 comment
Closed

Comments

@SgtPooki
Copy link
Member

Describe the bug
I ran aegir check-project on ipfs/js-kubo-rpc-client@167109a and it updated the README incorrectly in one area.

To Reproduce
Steps to reproduce the behavior:

cd $(mktemp -d)
git clone https://github.com/ipfs/js-kubo-rpc-client.git
cd js-kubo-rpc-client
git checkout 167109aadfc5fe681c8dae10749973040edd6d8b
npm install
./node_modules/.bin/aegir check-project
# Enter through all the prompts (accept the defaults)

Note the incorrect update to the readme.

the part of the diff that is incorrect (uses issue link for js-ipfs-unixfs-importer repo):

-Contributions welcome! Please check out [the issues](https://github.com/ipfs/js-kubo-rpc-client/issues).
+Feel free to join in. All welcome. Open an [issue](https://github.com/ipfs/js-ipfs-unixfs-importer/issues)!

Expected behavior
diff should be

-Contributions welcome! Please check out [the issues](https://github.com/ipfs/js-kubo-rpc-client/issues).
+Feel free to join in. All welcome. Open an [issue](https://github.com/ipfs/js-kubo-rpc-client/issues)!
SgtPooki added a commit to ipfs/js-kubo-rpc-client that referenced this issue Aug 24, 2022
Note that the README.md issue mentioned at ipfs/aegir#1056 was corrected manually
@achingbrain
Copy link
Member

Fixed by #1049 and released in 37.5.2 - please reopen if you're still seeing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants