Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check-project uses correct projectDir #1055

Merged
merged 2 commits into from
Aug 30, 2022
Merged

fix: check-project uses correct projectDir #1055

merged 2 commits into from
Aug 30, 2022

Conversation

SgtPooki
Copy link
Member

fixes #1054

@SgtPooki SgtPooki self-assigned this Aug 23, 2022
achingbrain
achingbrain requested changes Aug 26, 2022
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable but the types are failing.

From the error it seems projectDir's type is now string | number and it needs to be string.

@achingbrain achingbrain merged commit 297ac8f into master Aug 30, 2022
@achingbrain achingbrain deleted the SgtPooki-fix-1054 branch August 30, 2022 08:20
github-actions bot pushed a commit that referenced this pull request Aug 30, 2022
@semantic-release-bot
chore(release): 37.5.2 [skip ci]
c04a0f7 
## [37.5.2](v37.5.1...v37.5.2) (2022-08-30)

### Bug Fixes

* check-project uses correct projectDir ([#1055](#1055)) ([297ac8f](297ac8f)), closes [#1054](#1054)
* correct link to issues page for ipfs readmes ([#1049](#1049)) ([b3578e8](b3578e8))

### Dependencies

* bump @electron/get from 1.14.1 to 2.0.0 ([#1038](#1038)) ([d3fa53f](d3fa53f))
* bump strip-json-comments from 4.0.0 to 5.0.0 ([#1023](#1023)) ([aa14ef9](aa14ef9))
* bump update-notifier from 5.1.0 to 6.0.2 ([#1013](#1013)) ([3465038](3465038))
* **dev:** bump electron from 19.0.14 to 20.1.0 ([#1058](#1058)) ([b0cb84f](b0cb84f))
@github-actions
Copy link

🎉 This PR is included in version 37.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain requested changes

Assignees

@SgtPooki SgtPooki

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx aegir check-project fails to recognize projectDir correctly
2 participants
@SgtPooki @achingbrain