Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boxo #217

Closed
wants to merge 2 commits into from
Closed

Boxo #217

wants to merge 2 commits into from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 20, 2023 •
edited
Loading

@Jorropo Jorropo requested review from lidel, hacdias and a team as code owners March 20, 2023 22:01
This was referenced Mar 20, 2023
Closed
Closed
Closed
Closed
@Jorropo Jorropo force-pushed the boxo branch 2 times, most recently from b35e5b1 to 1b3d90a Compare March 20, 2023 22:41
@Jorropo Jorropo mentioned this pull request Mar 20, 2023
Closed
@Jorropo Jorropo force-pushed the boxo branch 2 times, most recently from f227165 to 2606ad5 Compare March 20, 2023 23:53
@Jorropo Jorropo mentioned this pull request Mar 21, 2023
Closed
@Jorropo Jorropo marked this pull request as draft March 21, 2023 01:00
guseggert
guseggert reviewed Mar 21, 2023
View reviewed changes
version.json Outdated Show resolved Hide resolved
@github-actions
Copy link

Suggested version: v0.8.0

Comparing to: v0.7.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.7.1

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

guseggert
guseggert reviewed Mar 21, 2023
View reviewed changes
README.md
Comment on lines 70 to +72
### Is everything related to IPFS in the Go ecosystem in this repo?

No. Not everything related to IPFS is intended to be in go-libipfs. View it as a starter toolbox (potentially among multiple). If you’d like to build an IPFS implementation with Go, here are some tools you might want that are maintained by a group that has long term commitments to the IPFS project. There are certainly repos that others maintainer that aren't included here (e.g., ipfs/go-car) which are still useful to IPFS implementations. It's expected and fine for new IPFS functionality to be developed that won't be part of go-libipfs.
No. Not everything related to IPFS is intended to be in Boxo. View it as a starter toolbox (potentially among multiple). If you’d like to build an IPFS implementation with Go, here are some tools you might want that are maintained by a group that has long term commitments to the IPFS project. There are certainly repos that others maintainer that aren't included here (e.g., ipfs/go-car) which are still useful to IPFS implementations. It's expected and fine for new IPFS functionality to be developed that won't be part of Boxo.
Copy link
Contributor

@guseggert guseggert Mar 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this section anymore (nor the "Does Boxo == IPFS?" section)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it hurts though to have this though to be clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep this too.

@BigLep BigLep mentioned this pull request Mar 22, 2023
Closed
@Jorropo Jorropo mentioned this pull request Mar 22, 2023
Merged
@Jorropo
Copy link
Contributor Author

Jorropo commented Mar 22, 2023

Closed in favor of #220

@Jorropo Jorropo closed this Mar 22, 2023
@Jorropo Jorropo deleted the boxo branch March 22, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert guseggert left review comments

@BigLep BigLep BigLep left review comments

@lidel lidel Awaiting requested review from lidel lidel is a code owner

@hacdias hacdias Awaiting requested review from hacdias

Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename go-libipfs to boxo
3 participants
@Jorropo @BigLep @guseggert