Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice/test: passthrough blockservice options [skip changelog] #449

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Wondertan
Copy link
Member

Self-explanatory

@Wondertan Wondertan requested a review from a team as a code owner August 22, 2023 12:06
@Wondertan
Copy link
Member Author

Wondertan commented Aug 22, 2023

Btw @Jorropo, what's the status of go-merkledag repo? Is it supposed to be migrated to boxo or moved into?

We use https://github.com/ipfs/go-merkledag/blob/master/test/utils.go#L20 from it and it depends on the old blockservice, so for now I decided to use canonical test utils defined in this pkg

Nvm, found https://github.com/ipfs/boxo/tree/main/ipld/merkledag

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #449 (9b0b846) into main (6a4bf9e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   61.25%   61.25%   -0.01%     
==========================================
  Files         205      205              
  Lines       24399    24399              
==========================================
- Hits        14946    14945       -1     
- Misses       8011     8012       +1     
  Partials     1442     1442              
Files Changed Coverage Δ
blockservice/test/mock.go 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@hacdias hacdias enabled auto-merge (rebase) August 22, 2023 13:38
@hacdias hacdias merged commit 303595b into ipfs:main Aug 22, 2023
11 checks passed
@Wondertan Wondertan deleted the blockservice-mock-options branch August 22, 2023 15:43
@BigLep
Copy link
Contributor

BigLep commented Aug 22, 2023

Nvm, found https://github.com/ipfs/boxo/tree/main/ipld/merkledag

There is discussion in the README as well: https://github.com/ipfs/go-merkledag#status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants