Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove support for legacy ipfs-404.html #509

Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: remove support for legacy ipfs-404.html #509

merged 1 commit into from
Nov 7, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 7, 2023

Closes #498.

@hacdias hacdias self-assigned this Nov 7, 2023
@hacdias hacdias requested review from lidel and a team as code owners November 7, 2023 10:17
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Merging #509 (e2ed59f) into main (a966a74) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   65.66%   65.65%   -0.01%     
==========================================
  Files         207      207              
  Lines       25604    25550      -54     
==========================================
- Hits        16814    16776      -38     
+ Misses       7319     7304      -15     
+ Partials     1471     1470       -1
Files Coverage Δ
gateway/handler.go 76.67% <ø> (-0.69%) ⬇️
gateway/handler_unixfs__redirects.go 37.82% <ø> (-10.73%) ⬇️

... and 19 files with indirect coverage changes

Jorropo
Jorropo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@hacdias hacdias merged commit f1442f7 into main Nov 7, 2023
14 checks passed
@hacdias hacdias deleted the remove-legacy-ipfs-404 branch November 7, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gateway: remove support for legacy ipfs-404.html
2 participants
@hacdias @Jorropo