Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all go-log import to v2 #513

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: all go-log import to v2 #513

merged 1 commit into from
Nov 15, 2023

Conversation

Dreamacro
Copy link
Contributor

Seems like an oversight when migrating bootstrap and peering.

@Dreamacro Dreamacro requested a review from a team as a code owner November 15, 2023 08:51
Copy link

welcome bot commented Nov 15, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #513 (0e6bf18) into main (50f8a08) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   65.57%   65.55%   -0.02%     
==========================================
  Files         207      207              
  Lines       25540    25540              
==========================================
- Hits        16748    16743       -5     
- Misses       7324     7325       +1     
- Partials     1468     1472       +4     
Files Coverage Δ
bootstrap/bootstrap.go 32.54% <ø> (ø)
peering/peering.go 75.40% <ø> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this!

@hacdias hacdias merged commit fe55533 into ipfs:main Nov 15, 2023
11 of 12 checks passed
@Dreamacro Dreamacro deleted the go-log branch November 15, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants