fix(gateway): do not act on template errors #515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487. When we try to execute a template, we have already written the header. In some places, we were already ignoring the template execution error. In others, we were calling
webError
. That would lead to a duplicate header writing warning.There is not much that can be done if a template fails to execute: we could perhaps log it, but so far what we've done in other places is to ignore. A way to circumvent this would be to write to a buffer and then write to
http.ResponseWriter
. That would allow us to catch the template error, but writing can always fail (e.g., broken connection).I wouldn't care much about this and I think just ignoring the template writing error is probably fine. If errors happen, they will most likely be writing errors, so broken connections and other network issues, most likely.