Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pinning): add support for names #525

Merged
merged 2 commits into from
Jan 4, 2024
Merged

feat(pinning): add support for names #525

merged 2 commits into from
Jan 4, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 15, 2023

Adds the long awaited support for labels for pins (ipfs/kubo#4586). The support was already kinda there, just needed to be plumbed out. This might not be the best approach and I think the pinning code is quite convoluted in general. But it works.

See ipfs/kubo#10261

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (79cace5) 65.62% compared to head (57031e8) 65.60%.
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   65.62%   65.60%   -0.03%     
==========================================
  Files         207      207              
  Lines       25562    25579      +17     
==========================================
+ Hits        16776    16781       +5     
- Misses       7319     7327       +8     
- Partials     1467     1471       +4     
Files Coverage Δ
pinning/pinner/pin.go 32.35% <ø> (ø)
provider/provider.go 0.00% <0.00%> (ø)
pinning/pinner/dspinner/pin.go 58.90% <74.41%> (+0.40%) ⬆️

... and 13 files with indirect coverage changes

pinning/pinner/dspinner/pin.go Outdated Show resolved Hide resolved
@hacdias hacdias changed the title feat(pinning): add support for labels feat(pinning): add support for name Jan 2, 2024
@hacdias hacdias changed the title feat(pinning): add support for name feat(pinning): add support for names Jan 2, 2024
@hacdias hacdias requested a review from lidel January 2, 2024 15:44
@hacdias hacdias marked this pull request as ready for review January 3, 2024 13:29
@hacdias hacdias requested a review from a team as a code owner January 3, 2024 13:29
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ipfs/kubo#10261 and lgtm.

@hacdias hacdias merged commit 38fb74f into main Jan 4, 2024
13 checks passed
@hacdias hacdias deleted the pin-labels branch January 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants