blockservice: fix panic when closing an offline blockservice #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockservice is explicitely tolerent to having a nil exchange. The constructor even logs that as running an offline blockservice. Everything is tolerent except close, which panics. It is confusing for consumers to only have to call close based on if it's online or offline. They could also instead call close directly on the exchange (then we could remove blockservice's Close method). Anyway here is as a simple fix, add a nil check.
Codecov ReportAttention:
@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 65.53% 65.61% +0.08%
==========================================
Files 207 207
Lines 25559 25562 +3
==========================================
+ Hits 16750 16773 +23
+ Misses 7337 7318 -19
+ Partials 1472 1471 -1
|
hacdias
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockservice is explicitely tolerent to having a nil exchange. The constructor even logs that as running an offline blockservice.
Everything is tolerent except close, which panics.
It is confusing for consumers to only have to call close based on if it's online or offline. They could also instead call close directly on the exchange (then we could remove blockservice's Close method).
Anyway here is as a simple fix, add a nil check.