namesys: add WithMaxCacheTTL #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 65.63% 65.57% -0.06%
==========================================
Files 207 207
Lines 25593 25605 +12
==========================================
- Hits 16797 16790 -7
- Misses 7323 7340 +17
- Partials 1473 1475 +2
|
2 tasks
lidel
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
lgtm, if this global ceiling overrides DNS-specific DNS.MaxCacheTTL we can clarify that in Kubo docs in ipfs/kubo#10321.
hacdias
force-pushed
the
namesys-maxcachettl
branch
from
9d5d582
to
d95a957
Compare
It does not because the DNS Resolver does not return the TTL. So that is fine. If it ever happens to return a TTL - consequently caching the DNSLink entries too in Namesys - we can update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxo part of #545.
I want to note that this TTL does not apply to DNS ONLY because the DNSResolver does not provide TTL values. It's important to note that the Namesys cache is oblivious regarding which resolver is backing it. In practice, it only caches IPNS records.
Kubo ipfs/kubo#10321