Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipns: fix test by using global random reader #586

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 6, 2024

I think this may fix the test that was intermittently failing on Windows. By using the global crypto/rand.Reader we avoid creating two different random generators seeded with the same time, and therefore likely generating the same key.

@hacdias hacdias requested a review from a team as a code owner March 6, 2024 10:38
@hacdias hacdias self-assigned this Mar 6, 2024
@hacdias hacdias requested a review from lidel March 6, 2024 10:43
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (2559ec2) to head (68da08c).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   59.94%   59.83%   -0.12%     
==========================================
  Files         232      232              
  Lines       28127    28127              
==========================================
- Hits        16861    16829      -32     
- Misses       9798     9821      +23     
- Partials     1468     1477       +9     

see 8 files with indirect coverage changes

@hacdias
Copy link
Member Author

hacdias commented Mar 19, 2024

This is a relatively small change. I will merge in hopes this will indeed fix the issue. We shall see.

@hacdias hacdias merged commit bff10de into main Mar 19, 2024
13 checks passed
@hacdias hacdias deleted the global-test-randreader branch March 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

1 participant