feat(routing/http/server): improve ux of /ipns #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Content-Disposition` with meaningful file extension - default to application/vnd.ipfs.ipns-record when `Accept` is missing
aschmahmann
reviewed
Mar 27, 2024
There was a problem hiding this comment.
LGTM, although @hacdias has been spending more time in this code than I have 😅
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 59.78% 59.85% +0.06%
==========================================
Files 232 232
Lines 28124 28135 +11
==========================================
+ Hits 16815 16839 +24
+ Misses 9837 9822 -15
- Partials 1472 1474 +2
|
Added support and test for wildcard value which is sent by every browser Accept: text/plain,*/*" on match, we default to default response type, the same way as when Accept is missing
hacdias
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Dispositionwith meaningful file extensionAcceptis missing or includes*/*wildcard.