Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap: add missing client options to exchange #597

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 8, 2024

No description provided.

@hacdias hacdias self-assigned this Apr 8, 2024
@hacdias hacdias marked this pull request as ready for review April 8, 2024 10:23
@hacdias hacdias requested a review from a team as a code owner April 8, 2024 10:23
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 59.86%. Comparing base (3a31820) to head (6c19374).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   59.88%   59.86%   -0.02%     
==========================================
  Files         232      232              
  Lines       28135    28139       +4     
==========================================
- Hits        16848    16845       -3     
- Misses       9820     9823       +3     
- Partials     1467     1471       +4     
Files Coverage Δ
bitswap/options.go 40.00% <0.00%> (-4.45%) ⬇️

... and 15 files with indirect coverage changes

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we've missed/never needed them before?

@hacdias hacdias merged commit 5fc25a4 into main Apr 9, 2024
13 checks passed
@hacdias hacdias deleted the bitswap-missing-options branch April 9, 2024 06:08
wenyue pushed a commit to wenyue/boxo that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants