Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delegated routing of legacy RSA peerids #609

Merged
merged 1 commit into from
May 15, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented May 14, 2024

This PR continues work from #585 which fixed support for ED25519 as BAse58. Here, we add correct support for RSA PeerIDs.

I also added test matrix for all PeerID variants versions to ensure we don't regress.

After this is merged, /routing/v1/peers endpoint will accept all variants of PeerIDs we see in the wild.

Namely:

  • cidv1-libp2p-key-ed25519-peerid
  • base58-ed25519-peerid
  • cidv1-libp2p-key-rsa-peerid
  • base58-rsa-peerid

@hacdias if this looks good, mind bubbling up to Someguy, and making new release, and deploying to https://delegated-ipfs.dev/?

@lidel lidel requested a review from a team as a code owner May 14, 2024 22:42

This comment was marked as outdated.

This ensures /routing/v1/peers endpoint accepts all variants of PeerIDs
we see in the wild, namely:

- cidv1-libp2p-key-ed25519-peerid
- base58-ed25519-peerid
- cidv1-libp2p-key-rsa-peerid
- base58-rsa-peerid
@lidel lidel force-pushed the fix/delegated-routing-legacy-rsa-peerids branch from 31123dc to d5c1c6c Compare May 14, 2024 22:53
@hacdias hacdias changed the title fix: deleagted routing of legacy RSA peerids fix: delegated routing of legacy RSA peerids May 15, 2024
@hacdias hacdias merged commit ac0bab3 into main May 15, 2024
14 checks passed
@hacdias hacdias deleted the fix/delegated-routing-legacy-rsa-peerids branch May 15, 2024 08:34
wenyue pushed a commit to wenyue/boxo that referenced this pull request Oct 17, 2024
This ensures /routing/v1/peers endpoint accepts all variants of PeerIDs
we see in the wild, namely:

- cidv1-libp2p-key-ed25519-peerid
- base58-ed25519-peerid
- cidv1-libp2p-key-rsa-peerid
- base58-rsa-peerid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants