Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch coverage to codecov #219

Closed
Kubuxu opened this issue Dec 16, 2016 · 9 comments
Closed

Switch coverage to codecov #219

Kubuxu opened this issue Dec 16, 2016 · 9 comments
Assignees

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Dec 16, 2016

Codecov has, IHMO, superior UI and UX and support that actually exists than Coveralls.

Go repos either starting to report to it or switching slowly if they were reporting before.

Would js side be for the switch over all to Codecov, as I know you are using coveralls currently?
This would allow us to unify it over the organizations.

cc @diasdavid @dignifiedquire @victorbjelkholm

@RichardLitt
Copy link
Member

Related to ipfs-inactive/project-repos#90 (comment).

@dignifiedquire
Copy link
Member

I don't have a particular preference, coveralls was just the easiest to setup. Happy to take a look at codecov.

@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 17, 2016

I just seen that aegir doesn't have support for codecov, I am possitive that it would possible to add it in the same manner that coveralls is wired in using https://github.com/codecov/codecov-node.

I will create PR to aegir.

@daviddias
Copy link
Member

@Kubuxu same feeling as @dignifiedquire, I just have the request that if we go forward with this, please make sure to track and update all of the modules (or divide the tasks), this is a lot of grunt work that takes a lot of time.

@daviddias
Copy link
Member

@dignifiedquire is this change coming with the new aegir?

@dignifiedquire
Copy link
Member

support for both is there already

@daviddias
Copy link
Member

daviddias commented Nov 20, 2017

I feel that Coveralls was so much nicer, it would give me the UI of a single line in the CI checks that told me if coverage dropped, maintained or increased. Now with codecov we get this giant reports which do not translate to anything on the CI checks:

image

It makes it really easy to ignore

@Kubuxu
Copy link
Member Author

Kubuxu commented Nov 20, 2017

I disable comments on all go repos and use Codecov interface and build status. There are two build status checks with Codecov: global coverage difference and diff coverage.

@Kubuxu
Copy link
Member Author

Kubuxu commented Nov 20, 2017

If you want comments, you can configure them: https://github.com/codecov/support/wiki/Pull-Request-Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants