-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Front end design & cleanup #14
Conversation
* JavaScript | ||
* bundeling using webpack | ||
* transpiling using babel | ||
* Linting using eslint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these required? why can't we keep these out? it makes it daunting to modify websites when suddenly you have to know a ton more tools and know how to debug them when something goes wrong.
there's a lot to be said for simplicity and reducing cognitive complexity to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of major points why I think we need them
- Manage dependencies using npm
- Consistency with other browser based modules like
js-ipf-api
- Make my life easier when working on the code (livereload is really a must for web dev for me)
The only thing that might not be needed is harpjs, though it was just a lot faster for me to use something working like that, than implementing all the tooling manually.
For me this is a lot simpler and more straight forward setup, especially while working with it than it was before. Also this enables me to add things like proper minification and asset bundeling which we need to have to ship this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sounds good. let's ship it
@dignifiedquire this looks fantastic 👍 👏 i think this is the way to go. |
@dignifiedquire i'm super happy with how this turned out. thank you for taking all the feedback and finding a great way to satisfy all the crazy constraints, and still make it look great :) 👍 |
Thanks, happy to hear that 🎉 🎈 |
[WIP] Front end design & cleanup
@dignifiedquire ahh sorry i merged too fast-- just recalled the open checkboxes. It's ok, maybe just continue with a PR on top. |
@jbenet no problem, will continue to create prs for the rest of the issues |
Hopefully closes #11 soon.
Current version:
Todo
harp compile
intomake
webpack
build intomake
You can run this via