-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizes colors, header #289
Conversation
- Adds IPFS logo (link) to header - Standardizes colors and fonts - Minor visual tweaks Closes #31
@dignifiedquire -- took a stab at an old issue. Can you please have a look and recommend any additional reviewers who should examine? Thank you! |
Makes room for sticky header
More air for left nav menu
Space above full-width buttons at narrower widths
removes colspans entirely in dist tables
full-width border-bottom in tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check the fonts in, but that's not a regression.
The jq dependency is breaking the build on my machine (transitive dependency contextify doesn't build). |
The jq you're installing is not the jq you think you're installing. |
@Stebalien Thanks for the reminder, totally forgot to uninstall that. |
|
Fixed. |
Oh my, that looks SO much better! |
@hsanjuan Do you mind a quick look, at @Stebalien's recommendation? Thanks! |
The menu offsets aren't quite right. When I scroll to the bottom, it still doesn't focus ipget. It should probably switch focus once both the header of the previous section scrolls off the screen (no idea how to actually implement that). |
First THIS IS SO MUCH BETTER JESSICA!! Awesome. 🎉 Re #289 (comment), what I see is that jumping to "ipfs-update" actually just focuses ipget. (still weird) Could we also tighten the padding on mobile: I want the CTA of clicking the "Download go-ipfs" button to be really clear - so making that a little bigger/brighter/bolder would be nice - maybe 18px? |
fix: ensure that clicking the last menu item works
|
Closes #31
Closes #254
Note: This is more of a "triage" fix than full CSS refactoring of the dist site; the intent is to take something that was pretty much unbranded and at least bring it into line with base colors, fonts etc. There are plenty of visual fixes that weren't made, but hopefully nothing is worse.