Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes colors, header #289

Merged
merged 19 commits into from
Apr 11, 2020
Merged

Standardizes colors, header #289

merged 19 commits into from
Apr 11, 2020

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Apr 10, 2020

  • Adds IPFS logo (link) to header
  • Standardizes colors and fonts
  • Minor visual tweaks

Closes #31
Closes #254

Note: This is more of a "triage" fix than full CSS refactoring of the dist site; the intent is to take something that was pretty much unbranded and at least bring it into line with base colors, fonts etc. There are plenty of visual fixes that weren't made, but hopefully nothing is worse.

- Adds IPFS logo (link) to header
- Standardizes colors and fonts
- Minor visual tweaks
Closes #31
@jessicaschilling
Copy link
Contributor Author

@dignifiedquire -- took a stab at an old issue. Can you please have a look and recommend any additional reviewers who should examine? Thank you!

Makes room for sticky header
More air for left nav menu
Space above full-width buttons at narrower widths
removes colspans entirely in dist tables
full-width border-bottom in tables
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check the fonts in, but that's not a regression.

site/layouts/_default/single.html Show resolved Hide resolved
@Stebalien
Copy link
Member

The jq dependency is breaking the build on my machine (transitive dependency contextify doesn't build).

@Stebalien
Copy link
Member

The jq you're installing is not the jq you think you're installing.

@jessicaschilling
Copy link
Contributor Author

@Stebalien Thanks for the reminder, totally forgot to uninstall that.

@Stebalien
Copy link
Member

make publish:

> dist.ipfs.io@1.0.0 build /home/steb/src/github.com/ipfs/distributions
> npm run dist && npm run build:assets && hugo -s site -d ../releases


> dist.ipfs.io@1.0.0 dist /home/steb/src/github.com/ipfs/distributions
> node scripts/dist.js

[Error: ENOENT: no such file or directory, open '/home/steb/src/github.com/ipfs/distributions/dists/img/current'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/steb/src/github.com/ipfs/distributions/dists/img/current'
}

@Stebalien
Copy link
Member

Fixed.

@Stebalien
Copy link
Member

Oh my, that looks SO much better!

@jessicaschilling
Copy link
Contributor Author

@hsanjuan Do you mind a quick look, at @Stebalien's recommendation? Thanks!

@Stebalien
Copy link
Member

The menu offsets aren't quite right. When I scroll to the bottom, it still doesn't focus ipget. It should probably switch focus once both the header of the previous section scrolls off the screen (no idea how to actually implement that).

@momack2
Copy link

momack2 commented Apr 11, 2020

First THIS IS SO MUCH BETTER JESSICA!! Awesome. 🎉

Re #289 (comment), what I see is that jumping to "ipfs-update" actually just focuses ipget. (still weird)

Could we also tighten the padding on mobile:
image

I want the CTA of clicking the "Download go-ipfs" button to be really clear - so making that a little bigger/brighter/bolder would be nice - maybe 18px?

@jessicaschilling
Copy link
Contributor Author

  • brightens hover states
  • bigger button text
  • tightens mobile layout

cc @Stebalien @momack2

@jessicaschilling
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Architecture matrix is ugly Add ipfs logo and make IPFS link to ipfs.io
4 participants