Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fleek deploy #177

Merged
merged 19 commits into from
Nov 20, 2023
Merged

feat: fleek deploy #177

merged 19 commits into from
Nov 20, 2023

Conversation

laurentsenta
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2046 0 0 0

@github-actions
Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2046 0 0 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurentsenta this works on CI, but there is no way to build locally, or on Fleek.
Was this intentional? Makes it very hard to maintain the thing, or move between providers.

I was unable to build locally cause there was no obvious script to run.
I've pushed my changes into this PR and then manually run Deploy in fleek app which builds from feat/fleek, but nothing changed. https://conformance-ipfs.on.fleek.co still shows old website.

Lmk if i am doing something wrong – meta comment is to simplify this.

Would it be possible to move build steps from this YAML into Makefile target named www?
If we could build the website locally with make www, then we could do the same on Fleek, removing the limitation of having website build being possible only in CI.

(Alternative ideas welcome, not being able to build locally is something we need to fix)

Copy link
Contributor Author

@laurentsenta laurentsenta Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidel We deploy fleek-deploy. feat/fleek is a temporary feature branch; it's used to trigger the build until we merge to main.

We're not "just" building a static website from the local content; For every build, we get the latest artifacts & assets from other repositories. So rational here was that Github tokens & Github-related code would stay in Github build system. We'd "just" deploy the build output (fleek-deploy) to fleek.

I get it's not super obvious how the whole thing work, I'll move the code to Makefile and scripts 👍

Copy link
Contributor Author

@laurentsenta laurentsenta Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidel I simplified the workflow so you can run it locally using make website (documented in the README).

(edited) A push to a branch won't trigger fleek, this is a known bug apparently.

Solution is to use a github token and have the deploy run in fleek. Benefit is that gives us deploy previews.

.github/workflows/deploy-pages.yml Show resolved Hide resolved
laurentsenta and others added 4 commits November 15, 2023 10:35
- make it more obvious how tests are categorized
- make it clear the conformance is wider than just HTTP Gateway
  funcitonality
- add canonical link
@laurentsenta laurentsenta force-pushed the feat/fleek branch 4 times, most recently from 3e3f80a to 509dbca Compare November 17, 2023 17:24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should change the logo since we adopted the 🐙 as, at least interim, logo of IPDX.

@laurentsenta laurentsenta merged commit 0775864 into main Nov 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants