-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fleek deploy #177
feat: fleek deploy #177
Conversation
Results against Kubo latest: Summary
|
Results against Kubo master: Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurentsenta this works on CI, but there is no way to build locally, or on Fleek.
Was this intentional? Makes it very hard to maintain the thing, or move between providers.
I was unable to build locally cause there was no obvious script to run.
I've pushed my changes into this PR and then manually run Deploy in fleek app which builds from feat/fleek
, but nothing changed. https://conformance-ipfs.on.fleek.co still shows old website.
Lmk if i am doing something wrong – meta comment is to simplify this.
Would it be possible to move build steps from this YAML into Makefile
target named www
?
If we could build the website locally with make www
, then we could do the same on Fleek, removing the limitation of having website build being possible only in CI.
(Alternative ideas welcome, not being able to build locally is something we need to fix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidel We deploy fleek-deploy
. feat/fleek
is a temporary feature branch; it's used to trigger the build until we merge to main.
We're not "just" building a static website from the local content; For every build, we get the latest artifacts & assets from other repositories. So rational here was that Github tokens & Github-related code would stay in Github build system. We'd "just" deploy the build output (fleek-deploy
) to fleek.
I get it's not super obvious how the whole thing work, I'll move the code to Makefile and scripts 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- make it more obvious how tests are categorized - make it clear the conformance is wider than just HTTP Gateway funcitonality - add canonical link
ee75253
to
8d6d7d0
Compare
8d6d7d0
to
12a6cbd
Compare
26fe055
to
a71d39c
Compare
3e3f80a
to
509dbca
Compare
8224a48
to
e05cf42
Compare
www/static/logo.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we should change the logo since we adopted the 🐙 as, at least interim, logo of IPDX.
No description provided.