fix(tests): properly test negative indexing #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the entity-bytes negative indexing test, fix the test so that it actually tests that the last block in the file is not read
lidel
reviewed
Dec 16, 2023
There was a problem hiding this comment.
Triage note for January: we may need to revisit this based on the result of discussion in ipfs/boxo#523 (comment)
tests/trustless_gateway_car_test.go
Outdated
| @@ -634,7 +634,7 @@ func TestTrustlessCarEntityBytes(t *testing.T) { | |||
| HasBlocks( | |||
| flattenStrings(t, | |||
| subdirWithMixedBlockFiles.MustGetCid("subdir", "multiblock.txt"), | |||
| subdirWithMixedBlockFiles.MustGetDescendantsCids("subdir", "multiblock.txt")[:5])..., | |||
| subdirWithMixedBlockFiles.MustGetDescendantsCids("subdir", "multiblock.txt")[:len(subdirWithMixedBlockFiles.MustGetDescendantsCids("subdir", "multiblock.txt"))-1])..., | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Wrote some thoughts in #112 (comment), but that work is separate from fix here, not a blocker.
This was referenced Jan 23, 2024
lidel
force-pushed
the
fix/range-conformance-test
branch
from
6a97c94
to
7ed58d1
Compare
lidel
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Fixed minor bugs and tested end-to-end in ipfs/kubo#10320, where CI is green.
Merging, will release as 0.5.x later this week (incl. bubbling up to Kubo/Boxo).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix #189
Implementation
Insure
entity-bytesnegative index test properly verifies that the last block of the underlying file is not read.