Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Use ipld.ErrNotFound #339

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Use ipld.ErrNotFound #339

merged 2 commits into from
Mar 17, 2022

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Apr 7, 2020

Rationale: ipfs/kubo#7074

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Apr 7, 2020

Depends on: ipfs/go-ipfs-blockstore#48

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 2, 2022

Tests are also broken on master. It's not this PR.

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Localy rebasing the PR to master fixed the tests.

@Jorropo
Copy link
Contributor

Jorropo commented Mar 17, 2022

Force pushed a master rebase to fix the tests.

EDIT: Didn't fixed the CI even tho it work locally (ah flaky tests <3), force pushed the force push away.

The commit of ipfs/go-ipfs-blockstore has been moved from the PR one to the master merged one to avoid deps breaking when github is gonna GC his PR commit.
@Jorropo Jorropo merged commit 3dda118 into master Mar 17, 2022
@Jorropo Jorropo deleted the fix/error-types branch March 17, 2022 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants