This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
check http status code during WebFile reads and return error for non-2XX #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Apr 22, 2019
|
Thanks! |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 11, 2023
check http status code during WebFile reads and return error for non-2XX This commit was moved from ipfs/go-ipfs-files@ed2c2b7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an HTTP status code check to
WebFile.Readso that non-2XX codes return an error. Before this change, the body of an error response would be accepted as the content, so e.g. a user might add a url for an object in a private cloud storage bucket and the cluster/node would silently hash an error message about not having access (this is how I discovered this).