Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it easy to use #142

Closed
wants to merge 1 commit into from
Closed

Conversation

zenzenless
Copy link

No description provided.

@welcome
Copy link

welcome bot commented Apr 7, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann
Copy link
Contributor

aschmahmann commented Jul 17, 2023

@james-zhang-bing can you add some justification here for why you've made the change to give reviewers some context?

@marten-seemann @ribasushi (pinging you since you merged some of the more recent commits) any thoughts?

@marten-seemann
Copy link
Member

I'd like to understand the motivation behind this change as well.

@lidel lidel added the need/author-input Needs input from the original author label Jul 31, 2023
@lidel
Copy link
Member

lidel commented Aug 7, 2023

Closing due to no response from PR author.
@james-zhang-bing if you feel this is needed please reopen with explanation why 🙏

@lidel lidel closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants