add global logger for some quick use #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Jun 15, 2020
There was a problem hiding this comment.
Thanks for the contribution but I'm not sure this pulls its weight. You should never actually use this logger in production and constructing a logger is pretty easy in practice.
Note: you can easily create a centralized logging package in your project to implement this, if it's really crucial.
| } | ||
|
|
||
| func ReplaceGlobalLogger(logger *ZapEventLogger) (undo func()) { | ||
| globalMu.Lock() |
There was a problem hiding this comment.
This isn't safe for concurrent use. You'd need to take the lock while accessing the global logger as well.
|
It is also a no for me. It is as simple as: to set up a logger. |
|
Personally I think a lib named |
|
This package is not trying to mimic go log's API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.