Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helia CI should run interop across all helia packages similar to kubo helia-interop ci #359

Closed
SgtPooki opened this issue Jan 4, 2024 · 4 comments
Closed

Helia CI should run interop across all helia packages similar to kubo helia-interop ci #359

SgtPooki opened this issue Jan 4, 2024 · 4 comments
Assignees
@SgtPooki

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jan 4, 2024 •
edited
Loading

see ipfs/kubo#10275 for more info
@Jorropo
Copy link

Jorropo commented Jan 4, 2024

Matching code in Kubo:

https://github.com/ipfs/kubo/blob/4a8badf98ea66ec926a0835542cbbcf0bd1f902e/.github/workflows/build.yml#L48-L96

(you would change it a bit, no need to compile Kubo from source, you can use the latest kubo prebuilt binary)

@SgtPooki SgtPooki self-assigned this Jan 4, 2024
@achingbrain achingbrain changed the title fix: helia CI should run interop across all helia packages similar to kubo helia-interop ci Helia CI should run interop across all helia packages similar to kubo helia-interop ci Jan 9, 2024
@achingbrain
Copy link
Member

achingbrain commented Jan 9, 2024 •
edited
Loading

As of #363 all @helia/* interop tests are in this repo so I think this can be closed?

no need to compile Kubo from source, you can use the latest kubo prebuilt binary

We already do, the interop tests use https://www.npmjs.com/package/kubo

Jorropo added a commit to ipfs/kubo that referenced this issue Jan 9, 2024
@Jorropo
ci: fix helia interop
bb2f359 
See ipfs/helia#359 (comment)
@Jorropo Jorropo mentioned this issue Jan 9, 2024
Merged
@Jorropo
Copy link

Jorropo commented Jan 9, 2024 •
edited
Loading

@achingbrain it sounds like it thx, could you please review ipfs/kubo#10283 ?

Jorropo added a commit to ipfs/kubo that referenced this issue Jan 9, 2024
@Jorropo
ci: fix helia interop
6ed5218 
Fixes #10275

See ipfs/helia#359 (comment)
Jorropo added a commit to ipfs/kubo that referenced this issue Jan 9, 2024
@Jorropo
ci: fix helia interop
96b6b98 
Fixes #10275

See ipfs/helia#359 (comment)
hacdias pushed a commit to ipfs/kubo that referenced this issue Jan 9, 2024
@Jorropo @hacdias
ci: fix helia interop
2f91074 
Fixes #10275

See ipfs/helia#359 (comment)
@Jorropo
Copy link

Jorropo commented Jan 9, 2024

🎉 thx

@Jorropo Jorropo closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
None yet
Projects
No open projects
Helia Working Group (inactive)
Status: 🎉 Done
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achingbrain @SgtPooki @Jorropo