You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<deni> IPFS desktop opens localhost:5001/ipfs/[hash] and companion redirects to localhost:8080/ipfs/[hash]
Background
This does not happen in companion alone, because it normalizes localhost to 127.0.0.1 to avoid mixed-content warnings in we browsers, and we already ignore gateways at 127.0.0.1.
@lidel I think it would be better for Companion to ignore gateways on localhost. I know Electron can register specific protocol handlers (like ipfs:// or dweb://) but as far as I've searched, I can't find information on how to open 'regular' URLs for a specific domain, which leads me to conclude that it is not easily possible.
@hacdias what I meant was to normalize localhost to 127.0.0.1 in API and Gateway port settings.
Eg. if user enters API port as localhost:5001, it should be replaced with the IP version.
(but yeah, on top of that, Companion should ignore localhost )
- ignored requests are identified early and cached across all
browser.webRequest.* hooks
- global toggle now correctly disables all hooks and workarounds
- Closes#604
- ignored requests are identified early and cached across all
browser.webRequest.* hooks
- global toggle now correctly disables all hooks and workarounds
- Closes#604
Background
This does not happen in companion alone, because it normalizes
localhost
to127.0.0.1
to avoid mixed-content warnings in we browsers, and we already ignore gateways at127.0.0.1
.Test Link: http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/
Fix
U guess we probably should do both:
localhost
127.0.0.1
instead oflocalhost
@hacdias thoughts?
The text was updated successfully, but these errors were encountered: