Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redirect opt-out to x-ipfs-companion-no-redirect #510

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 2, 2018

This is a tweak of #505, as suggested in #505 (comment)

@lidel lidel requested a review from olizilla July 2, 2018 09:39
README.md Outdated
@@ -45,7 +45,7 @@ If tested path is a valid IPFS address it gets redirected and loaded from a loca

It is possible to opt-out from redirect by
a) suspending extension via global toggle
b) including `x-ipfs-no-redirect` in the URL ([as a hash or query parameter](https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR?x-ipfs-no-redirect#x-ipfs-no-redirect)).
b) including `x-ipfs-companion-no-redirect` in the URL ([as a hash or query parameter](https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR?x-ipfs-companion-no-redirect#x-ipfs-companion-no-redirect)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'd be clearer as 2 separate example:

  • https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR?x-ipfs-companion-no-redirect
  • https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnRt#x-ipfs-companion-no-redirect

Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lidel lidel merged commit b2087e2 into master Jul 2, 2018
@lidel lidel deleted the change-opt-out-symbol branch July 2, 2018 09:53
@lidel
Copy link
Member Author

lidel commented Jul 2, 2018

Landed in v2.4.0.10120 (Beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants