Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6 #669

Closed
10 of 15 tasks
hacdias opened this issue Oct 15, 2018 · 11 comments
Closed
10 of 15 tasks

Release 0.6 #669

hacdias opened this issue Oct 15, 2018 · 11 comments

Comments

@hacdias
Copy link
Member

hacdias commented Oct 15, 2018

Disclaimer: the content of this main/first comment will be gradually updated with the current state and decisions related to this proccess.


Folllowing IPFS WebUI revamp, we're now focusing on IPFS Desktop. The main points are to make IPFS Desktop's UI more similar to the one we have on IPFS WebUI and also embbed WebUI in Desktop.

Checklist

Postponed

  • Storybook
  • Mount MFS on the File System (Mount MFS #618)
  • Way to connect to multiple backends

Tech Stack

  • Electron: version 3.0.0 just got out of Beta!
  • Building: we're replaceing Electron Forge by Electron Builder, which is more widely used so we can conclude it is more tested and more reliable. It is also easier to use and less buggy so far.
  • React as our UI framework.
@hacdias hacdias added the revamp label Oct 15, 2018
@hacdias hacdias changed the title design: wireframing [Revamp] Design Oct 15, 2018
@hacdias hacdias mentioned this issue Oct 16, 2018
@hacdias hacdias changed the title [Revamp] Design [Revamp] Master Issue Oct 16, 2018
@hacdias
Copy link
Member Author

hacdias commented Oct 16, 2018

Ping @ipfs-shipyard/gui for feedback!

@lidel
Copy link
Member

lidel commented Oct 17, 2018

I would move "Mount MFS on the File System" to postponed features.
"Way to connect to multiple backends" may also be a huge time sink if we want to get UI right, I'd say its "nice to have, but not mandatory to ship first iteration".

@alanshaw
Copy link
Member

😱 that PR is 300 files - I'm not going to be able to review that! How can we fix?

I'm super happy we have a master issue and some issues for tasks. This is a good start. We need to make sure the other tasks get tickets with context and info on what they are before we start work on them.

I would move "Mount MFS on the File System" to postponed features.

+1

@olizilla
Copy link
Member

Let's reframe this issue as the v1.0.0 release checklist rather than "revamp master issue". We can tag issues with v1 if it's important to make that distinction. Every major release will feel a bit like a revamp so it'll help us in the future to have specific version numbers rather than multiple events named 'revamp'.

We can have a v1 branch, while we get the basics figured out, and once we have a plan with some time estimates, we branch v0.5 from master, tag it, and merge v1 into master. (let's do this sooner than we did with webui.)

Longer general design discussions can be pulled out to issues on the ipfs-gui repo. Desktop specific design issues can be done as issues on this repo and tagged with discussion.

@hacdias hacdias changed the title [Revamp] Master Issue Release V1.0 Oct 18, 2018
@hacdias hacdias changed the title Release V1.0 Release 1.0 Oct 18, 2018
@hacdias hacdias added this to the v1.0 milestone Oct 18, 2018
@hacdias hacdias removed the revamp label Oct 18, 2018
@hacdias
Copy link
Member Author

hacdias commented Oct 18, 2018

@olizilla just removed the label revamp and added the related issues to milestone v1.0. Design discussion was also moved to ipfs-gui repo.

@alanshaw @lidel about postponing "Mount MFS on the File System": do you think we should do it because the 'system' isn't ready yet or because it isn't a crucial feature even though the main feature the user will want is to add files do IPFS?

@lidel
Copy link
Member

lidel commented Oct 18, 2018

@hacdias I'd say it is not ready yet (#618 (comment)): mounting MFS has a lot of hidden complexity and could be a significant time sink that delays initial release of revamped ipfs-desktop.
There is no reason to rush it. We need to design the experience first, research how it could work on various operating systems etc.

@hacdias hacdias mentioned this issue Nov 3, 2018
hacdias added a commit that referenced this issue Nov 14, 2018
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Nov 22, 2018

@ipfs-shipyard/gui should we aim to get signed binaries for this release?

@olizilla
Copy link
Member

Yes! That is how we will honour the 1.0 release!

@olizilla olizilla changed the title Release 1.0 Release 0.6 Dec 5, 2018
@olizilla
Copy link
Member

olizilla commented Dec 5, 2018

Updated this to 0.6 release. It sends a confusing signal to users if we say Desktop is 1.0 if it's using a sub 1.0 ipfs implementation.

@hacdias hacdias removed this from the v0.6 milestone Dec 21, 2018
@daviddias
Copy link
Member

If helpful (aka not adding much more work for little benefit) consider proposing a timeline for the outstanding tasks and creating a pre-release test phase to ask our dearest community contributors to give it a spin.

@olizilla
Copy link
Member

olizilla commented Jan 8, 2019

The items that didn't make it to 0.6 are going into 0.7 #788

We'll create a pre-release for that one, announce it to the community for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants