Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: go-ipfs 0.10.0 #904

Merged
merged 1 commit into from
Oct 11, 2021
Merged

chore: go-ipfs 0.10.0 #904

merged 1 commit into from
Oct 11, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 7, 2021 •
edited
Loading

I wish we could automate this, or ideally, remove the need for hardcoding version number in the URLs (having /latest dir)

@filecorgi
Copy link
Contributor

  • Image optimization came back clean!
  • Vuepress build was successful!

docs/install/command-line.md:

  • Try using a more formal synonym here to elevate your writing. 
    ...hrough the command-line is handy if you plan on building applications and se...
                                           ^^^^^^^^^^^^^^^^
  • Possibly missing comma found. 
    ... Desktop can do, but at a more granular level since you can specify which co...
                                           ^^^^^
  • Insert a space between the numerical value and the unit symbol. 
    ...n.  # System requirements IPFS requires 512MiB of memory and can run an IPFS...
                                           ^^^^^^
  • Insert a space between the numerical value and the unit symbol. 
    ...ing. A base installation takes up about 12MB of disk space. One can enable a...
                                           ^^^^
  • The word ‘install’ is not a noun. 
    ...ove into the go-ipfs folder and run the install script:  Check that IPFS ins...
                                           ^^^^^^^
  • The word ‘install’ is not a noun. 
    ...ove into the go-ipfs folder and run the install script:  Test that IPFS has ...
                                           ^^^^^^^
  • The verb “check out” can sound colloquial in this context. Consider using a more formal alternative. 
    ...ons and services on top of the network! Check out the Command-line- quicks s...
                                           ^^^^^^^^^
  • After ‘the’, the verb ‘Initialize’ doesn’t fit. Is ‘Initialize’ spelled correctly? If ‘Initialize’ is the first word in a compound adjective, use a hyphen between the two words. Using the verb ‘Initialize’ as a noun may be non-standard. 
    ...quicks start guide and jump straight to the Initialize the repository section.
                                           ^^^^^^^^^^^^^^
  • Check of docs/install/recent-releases.md came back clean!

lidel
lidel commented Oct 7, 2021
View reviewed changes
docs/install/command-line.md
@@ -11,11 +11,11 @@ Installing IPFS through the command-line is handy if you plan on building applic

## System requirements

IPFS requires 512MiB of memory and can run an IPFS node on a Raspberry Pi. However, how much disk space your IPFS installation takes up depends on how much data you're sharing. A base installation takes up about 12MB of disk space, and the [default maximum disk storage](../how-to/configure-node.md) is set to 10GB.
IPFS requires 512MiB of memory and can run an IPFS node on a Raspberry Pi. However, how much disk space your IPFS installation takes up depends on how much data you're sharing. A base installation takes up about 12MB of disk space. One can enable automatic garbage collection via [--enable-gc](/reference/cli/#ipfs-daemon) and adjust the [default maximum disk storage](https://github.com/ipfs/go-ipfs/blob/v0.10.0/docs/config.md#datastorestoragemax) for data retrieved from other peers.
Copy link
Member Author

@lidel lidel Oct 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I had to clarify this because by default GC is disabled 😬

lidel
lidel commented Oct 7, 2021
View reviewed changes
docs/install/recent-releases.md
@@ -6,6 +6,10 @@ title: Recent releases

This section contains information about recent IPFS releases. You can find installation instructions, update information, and release notes here.

## [Go-IPFS 0.10](https://github.com/ipfs/go-ipfs/releases/tag/v0.10.0)
Copy link
Member Author

@lidel lidel Oct 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I think we could have JS that is fetching latest N releases via github API, removing the need for this.

@lidel lidel mentioned this pull request Oct 7, 2021
Closed
62 tasks
@BigLep BigLep mentioned this pull request Oct 8, 2021
Closed
@BigLep
Copy link
Contributor

BigLep commented Oct 8, 2021

Followup item to automate this: #905

@lidel lidel merged commit e02d6c1 into main Oct 11, 2021
@lidel lidel deleted the chore/go-ipfs.0.10.0 branch October 11, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnymatthews johnnymatthews johnnymatthews approved these changes

Assignees

@lidel lidel

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidel @filecorgi @BigLep @johnnymatthews