Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created library "get" that allows us to use ipget with code more easily. #91

Closed
wants to merge 8 commits into from

Conversation

faddat
Copy link

@faddat faddat commented Aug 19, 2021

  • go 1.17
  • re-organized so that we now have a library, "get"

@welcome
Copy link

welcome bot commented Aug 19, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@faddat faddat mentioned this pull request Aug 19, 2021
@faddat
Copy link
Author

faddat commented Aug 19, 2021

do you want to upgrade CI, or should I downgrade?

Super-terse ipfs downloader added to util.  Pass it a cid and a path,…
@faddat
Copy link
Author

faddat commented Aug 20, 2021

I think this is ready to go

@gammazero
Copy link
Contributor

@faddat Thank you for your interest in contributing to this project. Unfortunately, this is not currently the direction we want to go with ipget. We would prefer that a library, that wraps the ability to connect to a local or remote node or create a temporary node to fetch data from IPFS, exists as a separate project/repo.

I would recommend reusing your work here to create a project that does just that. At some point in the future, such a library may be used to replace the functionality inside ipget, making ipget a CLI utility built on top of that library. Or maybe ipget is eventually replaced by a cmd within that library repo.

Again, thank you, but I am closing this PR for the reason stated above.

@gammazero gammazero closed this Aug 24, 2021
@faddat
Copy link
Author

faddat commented Aug 27, 2021

Very fair, I was just thinking about the same thing.

@faddat
Copy link
Author

faddat commented Aug 27, 2021

Here's what I am thinking:

  • remove other code from my fork
  • Include an example app in my fork
  • Rename the whole thing "get"

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants