This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: resolution of .eth names via .eth.link #2373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eth TLD is not recognised by mainstream DNS, however ENS provides DNS compatibility service at .eth.link This change enables resolution of ENS names ending with .eth on systems that have regular DNS set up More context at the go-ipfs counterpart: ipfs/kubo#6448 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
parkan
approved these changes
Aug 20, 2019
alanshaw
approved these changes
Aug 21, 2019
|
Tests are passing, bundlesize check is failing due to permissions error |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.ethTLD is not recognised by mainstream DNS,however ENS provides DNS compatibility service at
.eth.linkThis change enables resolution of ENS names ending with
.ethon systems that have regular DNS set up:
cc @mcdee, @parkan